Commit f768134b authored by Matthias Körber's avatar Matthias Körber Committed by Commit Bot

[Autofill] Allow calling of |WebInputElement::IsPasswordField()|

Changed |PresubmitError| to |PresubmitPromptWarning| to allow the call.

Bug: 1013121
Change-Id: I1e38d8efb7c6bdf21568924e2cd51126a4e50aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852208Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#704587}
parent e58e8a24
......@@ -22,9 +22,9 @@ def _CheckNoDirectPasswordCalls(input_api, output_api):
files.append(f)
if len(files):
return [ output_api.PresubmitError(
'Do not call IsPasswordField() or FormControlType() directly but ' +
'use IsPasswordFieldForAutofill() and FormControlTypeForAutofill() ' +
return [ output_api.PresubmitPromptWarning(
'Consider to not call IsPasswordField() or FormControlType() directly ' +
'but use IsPasswordFieldForAutofill() and FormControlTypeForAutofill() ' +
'respectively. These declare text input fields as password fields ' +
'if they have been password fields in the past. This is relevant ' +
'for websites that allow to reveal passwords with a button that ' +
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment