Commit f7b4f019 authored by vchigrin's avatar vchigrin Committed by Commit bot

Use data_deps rather then deps for mojo_bindings.

Using deps caused pulling a bit of mojo code to chrome.exe. That
caused weird unresolved externatls problems during Windows GN build.

Review URL: https://codereview.chromium.org/876783003

Cr-Commit-Position: refs/heads/master@{#313126}
parent 81fe0e57
...@@ -54,6 +54,7 @@ ...@@ -54,6 +54,7 @@
# If set, output_dir is not added to include_dirs. # If set, output_dir is not added to include_dirs.
# #
# deps (optional) # deps (optional)
# data_deps (optional)
# visibility (optional) # visibility (optional)
# Normal meaning. # Normal meaning.
# #
...@@ -413,6 +414,9 @@ template("grit") { ...@@ -413,6 +414,9 @@ template("grit") {
if (defined(invoker.deps)) { if (defined(invoker.deps)) {
deps += invoker.deps deps += invoker.deps
} }
if (defined(invoker.data_deps)) {
data_deps = invoker.data_deps
}
} }
# This is the thing that people actually link with, it must be named the # This is the thing that people actually link with, it must be named the
......
...@@ -787,9 +787,8 @@ grit("resources") { ...@@ -787,9 +787,8 @@ grit("resources") {
deps = [ deps = [
":about_credits", ":about_credits",
":chrome_internal_resources_gen", ":chrome_internal_resources_gen",
"//chrome/browser/ui/webui/omnibox:mojo_bindings",
"//mojo/environment:chromium",
] ]
data_deps = [ "//chrome/browser/ui/webui/omnibox:mojo_bindings" ]
} }
# GYP version: chrome/chrome_resource.gyp:about_credits # GYP version: chrome/chrome_resource.gyp:about_credits
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment