[Dice] Change target of user menu profile card to settings/people

When the user is signed into Chrome and clicks the
profile card in the user menu, they are now directed
to chrome://settings/people.

Bug: 852092
Change-Id: I89c770869232956ae8fb00a61cad8ebb6375532f
Reviewed-on: https://chromium-review.googlesource.com/1102422Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567615}

chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc

@@ -67,7 +67,7 @@ const char* const kChromeSettingsSubPages[] = {
     chrome::kStylusSubPage,
 #else
     chrome::kCreateProfileSubPage,   chrome::kImportDataSubPage,
-    chrome::kManageProfileSubPage,
+    chrome::kManageProfileSubPage,   chrome::kPeopleSubPage,
 #endif
 };
 #endif  // !defined(OS_ANDROID)

chrome/browser/ui/views/profiles/profile_chooser_view.cc

@@ -669,12 +669,7 @@ void ProfileChooserView::ButtonPressed(views::Button* sender,
     if (dice_enabled_ &&
         SigninManagerFactory::GetForProfile(browser_->profile())
             ->IsAuthenticated()) {
-      if (!browser_->profile()->IsSyncAllowed() ||
-          HasAuthError(browser_->profile())) {
-        chrome::ShowSettings(browser_);
-      } else {
-        chrome::ShowSettingsSubPage(browser_, chrome::kSyncSetupSubPage);
-      }
+      chrome::ShowSettingsSubPage(browser_, chrome::kPeopleSubPage);
     } else {
       // Open settings to edit profile name and image. The profile doesn't need
       // to be authenticated to open this.

chrome/common/webui_url_constants.cc

@@ -292,6 +292,7 @@ const char kStylusSubPage[] = "stylus";
 #else
 const char kCreateProfileSubPage[] = "createProfile";
 const char kManageProfileSubPage[] = "manageProfile";
+const char kPeopleSubPage[] = "people";
 #endif  // defined(OS_CHROMEOS)
 #if defined(OS_WIN)
 const char kCleanupSubPage[] = "cleanup";

chrome/common/webui_url_constants.h

@@ -263,6 +263,7 @@ extern const char kImportDataSubPage[];
 extern const char kLanguageOptionsSubPage[];
 extern const char kManageProfileSubPage[];
 extern const char kPasswordManagerSubPage[];
+extern const char kPeopleSubPage[];
 extern const char kPrintingSettingsSubPage[];
 extern const char kResetProfileSettingsSubPage[];
 extern const char kSearchEnginesSubPage[];