Commit f84128b4 authored by kochi@chromium.org's avatar kochi@chromium.org

Comment objectType field of ApplicationResource, resolving TODO

With some comment fixes for style nits.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149603 0039d316-1c4b-4281-b951-d872f2087c98
parent 6f2f232c
...@@ -142,7 +142,8 @@ class AppResource { ...@@ -142,7 +142,8 @@ class AppResource {
const std::string& name() const { return name_; } const std::string& name() const { return name_; }
// Returns the name of the type of object this application creates. // Returns the name of the type of object this application creates.
// This can be any string. TODO(kochi): figure out how to use this value. // This is used for displaying in "Create" menu item for this app.
// If empty, application name is used instead.
const std::string& object_type() const { return object_type_; } const std::string& object_type() const { return object_type_; }
// Returns whether this application suuports creating new objects. // Returns whether this application suuports creating new objects.
......
...@@ -787,6 +787,7 @@ class GDataFileSystem : public GDataFileSystemInterface, ...@@ -787,6 +787,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
const std::string& resource_id, const std::string& resource_id,
const std::string& md5, const std::string& md5,
const FilePath& cache_file_path); const FilePath& cache_file_path);
// Callback for getting the size of the cache file in the blocking pool. // Callback for getting the size of the cache file in the blocking pool.
void OnGetFileSizeCompleteForUpdateFile( void OnGetFileSizeCompleteForUpdateFile(
const FileOperationCallback& callback, const FileOperationCallback& callback,
...@@ -795,6 +796,7 @@ class GDataFileSystem : public GDataFileSystemInterface, ...@@ -795,6 +796,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
const FilePath& cache_file_path, const FilePath& cache_file_path,
GDataFileError* error, GDataFileError* error,
int64* file_size); int64* file_size);
// Callback for GDataRootDirectory::GetEntryByResourceIdAsync. // Callback for GDataRootDirectory::GetEntryByResourceIdAsync.
void OnGetFileCompleteForUpdateFileByEntry( void OnGetFileCompleteForUpdateFileByEntry(
const FileOperationCallback& callback, const FileOperationCallback& callback,
...@@ -803,7 +805,6 @@ class GDataFileSystem : public GDataFileSystemInterface, ...@@ -803,7 +805,6 @@ class GDataFileSystem : public GDataFileSystemInterface,
const FilePath& cache_file_path, const FilePath& cache_file_path,
GDataEntry* entry); GDataEntry* entry);
// Called when GDataUploader::UploadUpdatedFile() is completed for // Called when GDataUploader::UploadUpdatedFile() is completed for
// UpdateFileByResourceId(). // UpdateFileByResourceId().
void OnUpdatedFileUploaded( void OnUpdatedFileUploaded(
......
...@@ -101,7 +101,7 @@ void GDataEntry::SetBaseNameFromTitle() { ...@@ -101,7 +101,7 @@ void GDataEntry::SetBaseNameFromTitle() {
base_name_ = EscapeUtf8FileName(title_); base_name_ = EscapeUtf8FileName(title_);
} }
// static. // static
GDataEntry* GDataEntry::FromDocumentEntry( GDataEntry* GDataEntry::FromDocumentEntry(
GDataDirectory* parent, GDataDirectory* parent,
DocumentEntry* doc, DocumentEntry* doc,
...@@ -115,7 +115,7 @@ GDataEntry* GDataEntry::FromDocumentEntry( ...@@ -115,7 +115,7 @@ GDataEntry* GDataEntry::FromDocumentEntry(
return NULL; return NULL;
} }
// static. // static
std::string GDataEntry::EscapeUtf8FileName(const std::string& input) { std::string GDataEntry::EscapeUtf8FileName(const std::string& input) {
std::string output; std::string output;
if (ReplaceChars(input, kSlash, std::string(kEscapedSlash), &output)) if (ReplaceChars(input, kSlash, std::string(kEscapedSlash), &output))
...@@ -124,7 +124,7 @@ std::string GDataEntry::EscapeUtf8FileName(const std::string& input) { ...@@ -124,7 +124,7 @@ std::string GDataEntry::EscapeUtf8FileName(const std::string& input) {
return input; return input;
} }
// static. // static
std::string GDataEntry::UnescapeUtf8FileName(const std::string& input) { std::string GDataEntry::UnescapeUtf8FileName(const std::string& input) {
std::string output = input; std::string output = input;
ReplaceSubstringsAfterOffset(&output, 0, std::string(kEscapedSlash), kSlash); ReplaceSubstringsAfterOffset(&output, 0, std::string(kEscapedSlash), kSlash);
...@@ -156,7 +156,7 @@ void GDataFile::SetBaseNameFromTitle() { ...@@ -156,7 +156,7 @@ void GDataFile::SetBaseNameFromTitle() {
} }
} }
// static. // static
GDataEntry* GDataFile::FromDocumentEntry( GDataEntry* GDataFile::FromDocumentEntry(
GDataDirectory* parent, GDataDirectory* parent,
DocumentEntry* doc, DocumentEntry* doc,
......
...@@ -157,7 +157,6 @@ GetDocumentsOperation::GetDocumentsOperation( ...@@ -157,7 +157,6 @@ GetDocumentsOperation::GetDocumentsOperation(
int start_changestamp, int start_changestamp,
const std::string& search_string, const std::string& search_string,
const std::string& directory_resource_id, const std::string& directory_resource_id,
const GetDataCallback& callback) const GetDataCallback& callback)
: GetDataOperation(registry, profile, callback), : GetDataOperation(registry, profile, callback),
start_changestamp_(start_changestamp), start_changestamp_(start_changestamp),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment