Commit f846b651 authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

Reland "[Sync:USS] Enable more two client bookmarks integration tests"

This is a reland of 94d8037b

Original change's description:
> [Sync:USS] Enable more two client bookmarks integration tests
> 
> This CL enables more integration tests for bookmarks to run
> against USS archiecture.
> 
> 
> Bug: 516866
> Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f
> Reviewed-on: https://chromium-review.googlesource.com/1158691
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580434}

Bug: 516866
Change-Id: Ia922ab75b92c013cc2e06cb3ec5a549875390316
Reviewed-on: https://chromium-review.googlesource.com/1161882Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580499}
parent 9569d21a
...@@ -451,7 +451,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -451,7 +451,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
} }
// Add bookmarks with different name and same URL. // Add bookmarks with different name and same URL.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
SC_DuplicateBookmarksWithSameURL) { SC_DuplicateBookmarksWithSameURL) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1234,7 +1234,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests, ...@@ -1234,7 +1234,7 @@ IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
ASSERT_TRUE(BookmarksMatchVerifierChecker().Wait()); ASSERT_TRUE(BookmarksMatchVerifierChecker().Wait());
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_BiDirectionalPushAddingBM) { MC_BiDirectionalPushAddingBM) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1252,7 +1252,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1252,7 +1252,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_BiDirectionalPush_AddingSameBMs) { MC_BiDirectionalPush_AddingSameBMs) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
...@@ -1269,14 +1269,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1269,14 +1269,14 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_TRUE(BookmarksMatchChecker().Wait()); ASSERT_TRUE(BookmarksMatchChecker().Wait());
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_BootStrapEmptyStateEverywhere) { MC_BootStrapEmptyStateEverywhere) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AwaitQuiescence()); ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_CaseInsensitivity_InNames) { MC_Merge_CaseInsensitivity_InNames) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1298,7 +1298,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1298,7 +1298,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_SimpleMergeOfDifferentBMModels) { MC_SimpleMergeOfDifferentBMModels) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1324,7 +1324,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1324,7 +1324,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchyUnderBMBar) { MC_MergeSimpleBMHierarchyUnderBMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1347,7 +1347,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1347,7 +1347,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
ASSERT_FALSE(ContainsDuplicateBookmarks(0)); ASSERT_FALSE(ContainsDuplicateBookmarks(0));
} }
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar) { MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1365,7 +1365,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1365,7 +1365,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge bookmark folders with different bookmarks. // Merge bookmark folders with different bookmarks.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeBMFoldersWithDifferentBMs) { MC_MergeBMFoldersWithDifferentBMs) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1388,7 +1388,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1388,7 +1388,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge moderately complex bookmark models. // Merge moderately complex bookmark models.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeDifferentBMModelsModeratelyComplex) { MC_MergeDifferentBMModelsModeratelyComplex) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1429,7 +1429,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1429,7 +1429,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge simple bookmark subset under bookmark folder. // Merge simple bookmark subset under bookmark folder.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchySubsetUnderBMFolder) { MC_MergeSimpleBMHierarchySubsetUnderBMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1454,7 +1454,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1454,7 +1454,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge subsets of bookmark under bookmark bar. // Merge subsets of bookmark under bookmark bar.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_MergeSimpleBMHierarchySubsetUnderBookmarkBar) { MC_MergeSimpleBMHierarchySubsetUnderBookmarkBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1478,7 +1478,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1478,7 +1478,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge simple bookmark hierarchy under bookmark folder. // Merge simple bookmark hierarchy under bookmark folder.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_SimpleBMHierarchy_Under_BMFolder) { MC_Merge_SimpleBMHierarchy_Under_BMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1509,7 +1509,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1509,7 +1509,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
// Merge disjoint sets of bookmark hierarchy under bookmark // Merge disjoint sets of bookmark hierarchy under bookmark
// folder. // folder.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BMFolder) { MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BMFolder) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1538,7 +1538,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1538,7 +1538,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge disjoint sets of bookmark hierarchy under bookmark bar. // Merge disjoint sets of bookmark hierarchy under bookmark bar.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(
TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BookmarkBar) { MC_Merge_SimpleBMHierarchy_DisjointSets_Under_BookmarkBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1561,7 +1562,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, ...@@ -1561,7 +1562,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
} }
// Merge sets of duplicate bookmarks under bookmark bar. // Merge sets of duplicate bookmarks under bookmark bar.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_Merge_SimpleBMHierarchy_DuplicateBMs_Under_BMBar) { MC_Merge_SimpleBMHierarchy_DuplicateBMs_Under_BMBar) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1621,7 +1622,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, DisableSync) { ...@@ -1621,7 +1622,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, DisableSync) {
} }
// Test adding duplicate folder - Both with different BMs underneath. // Test adding duplicate folder - Both with different BMs underneath.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, MC_DuplicateFolders) { IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
MC_DuplicateFolders) {
ASSERT_TRUE(SetupClients()) << "SetupClients() failed."; ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
DisableVerifier(); DisableVerifier();
...@@ -1970,7 +1972,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, RacyPositionChanges) { ...@@ -1970,7 +1972,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, RacyPositionChanges) {
// Trigger the server side creation of Synced Bookmarks. Ensure both clients // Trigger the server side creation of Synced Bookmarks. Ensure both clients
// remain syncing afterwards. Add bookmarks to the synced bookmarks folder // remain syncing afterwards. Add bookmarks to the synced bookmarks folder
// and ensure both clients receive the bookmark. // and ensure both clients receive the bookmark.
IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, CreateSyncedBookmarks) { IN_PROC_BROWSER_TEST_P(TwoClientBookmarksSyncTestIncludingUssTests,
CreateSyncedBookmarks) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
ASSERT_TRUE(AllModelsMatchVerifier()); ASSERT_TRUE(AllModelsMatchVerifier());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment