Commit f877c4ff authored by Mandy Chen's avatar Mandy Chen Committed by Commit Bot

DevTools: Localize accessibility strings and add descriptions

Accessibility strings in front_end/accessibility/AccessibilityStrings.js
are not localized. They are displayed in Elements pane -> Accessiblity
pane -> Computed Properties. See https://imgur.com/HtE1ZhP.

I wrap them in ls`` and add them to accessibility_strings.grdp file with
descriptions.

Description of a 'name' string:
Accessibility attribute name that appears under the Computed Properties
section in the Accessibility pane of the Elements pane

Description of a 'description' string:
Tooltip text that appears when hovering over the '<name>' attribute name
under the Computed Properties section in the Accessibility pane of the
Elements pane


Bug: 941561
Change-Id: I655760c02ee31ef4e22385c9dc003fd4152c93c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648332
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667327}
parent 038bf1d0
...@@ -164,7 +164,7 @@ Accessibility.AXNodePropertyTreeElement = class extends UI.TreeElement { ...@@ -164,7 +164,7 @@ Accessibility.AXNodePropertyTreeElement = class extends UI.TreeElement {
const nameElement = createElement('span'); const nameElement = createElement('span');
const AXAttributes = Accessibility.AccessibilityStrings.AXAttributes; const AXAttributes = Accessibility.AccessibilityStrings.AXAttributes;
if (name in AXAttributes) { if (name in AXAttributes) {
nameElement.textContent = ls(AXAttributes[name].name); nameElement.textContent = AXAttributes[name].name;
nameElement.title = AXAttributes[name].description; nameElement.title = AXAttributes[name].description;
nameElement.classList.add('ax-readable-name'); nameElement.classList.add('ax-readable-name');
} else { } else {
...@@ -392,8 +392,8 @@ Accessibility.AXValueSourceTreeElement = class extends Accessibility.AXNodePrope ...@@ -392,8 +392,8 @@ Accessibility.AXValueSourceTreeElement = class extends Accessibility.AXNodePrope
if (source.nativeSource) { if (source.nativeSource) {
const AXNativeSourceTypes = Accessibility.AccessibilityStrings.AXNativeSourceTypes; const AXNativeSourceTypes = Accessibility.AccessibilityStrings.AXNativeSourceTypes;
const nativeSource = source.nativeSource; const nativeSource = source.nativeSource;
nameElement.textContent = ls(AXNativeSourceTypes[nativeSource].name); nameElement.textContent = AXNativeSourceTypes[nativeSource].name;
nameElement.title = ls(AXNativeSourceTypes[nativeSource].description); nameElement.title = AXNativeSourceTypes[nativeSource].description;
nameElement.classList.add('ax-readable-name'); nameElement.classList.add('ax-readable-name');
break; break;
} }
...@@ -404,12 +404,12 @@ Accessibility.AXValueSourceTreeElement = class extends Accessibility.AXNodePrope ...@@ -404,12 +404,12 @@ Accessibility.AXValueSourceTreeElement = class extends Accessibility.AXNodePrope
default: default:
const AXSourceTypes = Accessibility.AccessibilityStrings.AXSourceTypes; const AXSourceTypes = Accessibility.AccessibilityStrings.AXSourceTypes;
if (type in AXSourceTypes) { if (type in AXSourceTypes) {
nameElement.textContent = ls(AXSourceTypes[type].name); nameElement.textContent = AXSourceTypes[type].name;
nameElement.title = ls(AXSourceTypes[type].description); nameElement.title = AXSourceTypes[type].description;
nameElement.classList.add('ax-readable-name'); nameElement.classList.add('ax-readable-name');
} else { } else {
console.warn(type, 'not in AXSourceTypes'); console.warn(type, 'not in AXSourceTypes');
nameElement.textContent = ls(type); nameElement.textContent = type;
} }
} }
this.listItemElement.appendChild(nameElement); this.listItemElement.appendChild(nameElement);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment