Commit f88ee785 authored by Scott Violet's avatar Scott Violet Committed by Commit Bot

blink: fix dependency

Some of the generated files depend upon mojoms in
//media/medi, but there is no dep. Without the dep the
build is flaky, and recently failed on arm64:

[63355/105864] CXX clang_x64_v8_arm64/obj/third_party/blink/renderer/bindings/modules/v8/v8/v8_midi_input.o
FAILED: clang_x64_v8_arm64/obj/third_party/blink/renderer/bindings/modules/v8/v8/v8_midi_input.o
/opt/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -...(too long)
In file included from clang_x64_v8_arm64/gen/third_party/blink/renderer/bindings/modules/v8/v8_midi_input.cc:8:
In file included from clang_x64_v8_arm64/gen/third_party/blink/renderer/bindings/modules/v8/v8_midi_input.h:12:
../../third_party/blink/renderer/modules/webmidi/midi_input.h:34:10: fatal error: 'media/midi/midi_service.m

BUG=none
TEST=none

No-Tree-Checks: true
Change-Id: Id72b0d095bf363fe6538205942d1612c64bf50c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391597
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: default avatarDana Fried <dfried@google.com>
Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803992}
parent 99e8eb34
......@@ -24,6 +24,7 @@ blink_modules_sources("v8") {
}
deps = [
":generate_mojo_bindings",
":generated",
"//third_party/blink/renderer/platform",
"//v8",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment