Commit f89bca7f authored by Etienne Bergeron's avatar Etienne Bergeron Committed by Commit Bot

Fix flakiness caused by ASAN on TracingControllerTest

NOTE TO CHROMIUM SHERIFF:
  If Tracing unittests are flaky, please revert this CL and ping me.

Change-Id: Ia4a6a57e190afd82eec4b133ce8e1f33bc6c1f0f
Reviewed-on: https://chromium-review.googlesource.com/c/1349495
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: default avataroysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611801}
parent 3ca20a18
...@@ -372,13 +372,7 @@ class TracingControllerTest : public ContentBrowserTest { ...@@ -372,13 +372,7 @@ class TracingControllerTest : public ContentBrowserTest {
std::string last_data_; std::string last_data_;
}; };
// TODO(crbug.com/871770): Disabled for failing on ASAN. IN_PROC_BROWSER_TEST_F(TracingControllerTest, GetCategories) {
#if defined(ADDRESS_SANITIZER)
#define MAYBE_GetCategories DISABLED_GetCategories
#else
#define MAYBE_GetCategories GetCategories
#endif
IN_PROC_BROWSER_TEST_F(TracingControllerTest, MAYBE_GetCategories) {
Navigate(shell()); Navigate(shell());
TracingController* controller = TracingController::GetInstance(); TracingController* controller = TracingController::GetInstance();
...@@ -392,13 +386,7 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, MAYBE_GetCategories) { ...@@ -392,13 +386,7 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, MAYBE_GetCategories) {
EXPECT_EQ(get_categories_done_callback_count(), 1); EXPECT_EQ(get_categories_done_callback_count(), 1);
} }
// TODO(crbug.com/871770): Disabled for failing on ASAN. IN_PROC_BROWSER_TEST_F(TracingControllerTest, EnableAndStopTracing) {
#if defined(ADDRESS_SANITIZER)
#define MAYBE_EnableAndStopTracing DISABLED_EnableAndStopTracing
#else
#define MAYBE_EnableAndStopTracing EnableAndStopTracing
#endif
IN_PROC_BROWSER_TEST_F(TracingControllerTest, MAYBE_EnableAndStopTracing) {
TestStartAndStopTracingString(); TestStartAndStopTracingString();
} }
...@@ -476,15 +464,8 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, NotWhitelistedMetadataStripped) { ...@@ -476,15 +464,8 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, NotWhitelistedMetadataStripped) {
// EXPECT_TRUE(KeyEquals(metadata_json, "not-whitelisted", "__stripped__")); // EXPECT_TRUE(KeyEquals(metadata_json, "not-whitelisted", "__stripped__"));
} }
// TODO(crbug.com/871770): Disabled for failing on ASAN.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_EnableAndStopTracingWithFilePath \
DISABLED_EnableAndStopTracingWithFilePath
#else
#define MAYBE_EnableAndStopTracingWithFilePath EnableAndStopTracingWithFilePath
#endif
IN_PROC_BROWSER_TEST_F(TracingControllerTest, IN_PROC_BROWSER_TEST_F(TracingControllerTest,
MAYBE_EnableAndStopTracingWithFilePath) { EnableAndStopTracingWithFilePath) {
base::FilePath file_path; base::FilePath file_path;
{ {
base::ScopedAllowBlockingForTesting allow_blocking; base::ScopedAllowBlockingForTesting allow_blocking;
...@@ -494,29 +475,13 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, ...@@ -494,29 +475,13 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest,
EXPECT_EQ(file_path.value(), last_actual_recording_file_path().value()); EXPECT_EQ(file_path.value(), last_actual_recording_file_path().value());
} }
// TODO(crbug.com/871770): Disabled for failing on ASAN.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_EnableAndStopTracingWithCompression \
DISABLED_EnableAndStopTracingWithCompression
#else
#define MAYBE_EnableAndStopTracingWithCompression \
EnableAndStopTracingWithCompression
#endif
IN_PROC_BROWSER_TEST_F(TracingControllerTest, IN_PROC_BROWSER_TEST_F(TracingControllerTest,
MAYBE_EnableAndStopTracingWithCompression) { EnableAndStopTracingWithCompression) {
TestStartAndStopTracingCompressed(); TestStartAndStopTracingCompressed();
} }
// TODO(crbug.com/871770): Disabled for failing on ASAN.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_EnableAndStopTracingWithEmptyFile \
DISABLED_EnableAndStopTracingWithEmptyFile
#else
#define MAYBE_EnableAndStopTracingWithEmptyFile \
EnableAndStopTracingWithEmptyFile
#endif
IN_PROC_BROWSER_TEST_F(TracingControllerTest, IN_PROC_BROWSER_TEST_F(TracingControllerTest,
MAYBE_EnableAndStopTracingWithEmptyFile) { EnableAndStopTracingWithEmptyFile) {
Navigate(shell()); Navigate(shell());
base::RunLoop run_loop; base::RunLoop run_loop;
...@@ -535,13 +500,7 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, ...@@ -535,13 +500,7 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest,
run_loop.Run(); run_loop.Run();
} }
// TODO(crbug.com/871770): Disabled for failing on ASAN. IN_PROC_BROWSER_TEST_F(TracingControllerTest, DoubleStopTracing) {
#if defined(ADDRESS_SANITIZER)
#define MAYBE_DoubleStopTracing DISABLED_DoubleStopTracing
#else
#define MAYBE_DoubleStopTracing DoubleStopTracing
#endif
IN_PROC_BROWSER_TEST_F(TracingControllerTest, MAYBE_DoubleStopTracing) {
Navigate(shell()); Navigate(shell());
base::RunLoop run_loop; base::RunLoop run_loop;
...@@ -560,11 +519,8 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, MAYBE_DoubleStopTracing) { ...@@ -560,11 +519,8 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, MAYBE_DoubleStopTracing) {
run_loop.Run(); run_loop.Run();
} }
// TODO(crbug.com/871770): Disabled for failing on ASAN.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_SystemTraceEvents DISABLED_SystemTraceEvents
// Only CrOS, and Cast support system tracing. // Only CrOS, and Cast support system tracing.
#elif defined(OS_CHROMEOS) || (defined(IS_CHROMECAST) && defined(OS_LINUX)) #if defined(OS_CHROMEOS) || (defined(IS_CHROMECAST) && defined(OS_LINUX))
#define MAYBE_SystemTraceEvents SystemTraceEvents #define MAYBE_SystemTraceEvents SystemTraceEvents
#else #else
#define MAYBE_SystemTraceEvents DISABLED_SystemTraceEvents #define MAYBE_SystemTraceEvents DISABLED_SystemTraceEvents
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment