[code coverage] Assign bots to linux-code-coverage

The internal linux-code-coverage builder doesn't run fuzzers anymore,
so it can be moved to external. This CL revives the external version
of linux-code-coverage, and once it accumulates enough reports, will
turn down the internal version.

Currently there are 4 32-cores ssd bots that are used by code coverage
builders, and there are 3 builders: linux-chromeos-code-coverage,
android-code-coverage and android-code-coverage-native, and the
android-code-coverage usually finishes fast (1h every 6h), therefore,
there is room for one more builder: linux-code-coverage.

Bug: 1016929
Change-Id: Ifeeb78fba69af0567857e905ced9a29196469528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974576Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726118}

infra/config/buckets/ci.star

@@ -1162,12 +1162,14 @@ def fyi_coverage_builder(
     *,
     name,
     cores=32,
+    ssd=True,
     execution_timeout=20 * time.hour,
     goma_backend=goma.backend.RBE_PROD,
     **kwargs):
   return fyi_builder(
       name = name,
       cores = cores,
+      ssd=ssd,
       execution_timeout = execution_timeout,
       goma_backend = goma_backend,
       **kwargs
@@ -1176,13 +1178,11 @@ def fyi_coverage_builder(
 fyi_coverage_builder(
     name = 'android-code-coverage',
     use_java_coverage = True,
-    ssd = True,
 )
 
 fyi_coverage_builder(
     name = 'android-code-coverage-native',
     use_clang_coverage = True,
-    ssd = True,
 )
 
 fyi_coverage_builder(
@@ -1199,13 +1199,11 @@ fyi_coverage_builder(
 
 fyi_coverage_builder(
     name = 'linux-chromeos-code-coverage',
-    ssd = True,
     use_clang_coverage = True,
 )
 
 fyi_coverage_builder(
     name = 'linux-code-coverage',
-    os = None,
     use_clang_coverage = True,
 )
 
@@ -1214,7 +1212,6 @@ fyi_coverage_builder(
     builderless = True,
     cores = 24,
     os = os.MAC_ANY,
-    ssd = True,
     use_clang_coverage = True,
 )
 
@@ -1223,7 +1220,6 @@ fyi_coverage_builder(
     builderless = True,
     goma_enable_ats = True,
     os = os.WINDOWS_DEFAULT,
-    ssd = True,
     use_clang_coverage = True,
 )
 

infra/config/generated/cr-buildbucket.cfg

@@ -6686,6 +6686,7 @@ buckets: <
       dimensions: "builder:ios-simulator-code-coverage"
       dimensions: "cpu:x86-64"
       dimensions: "os:Mac"
+      dimensions: "ssd:1"
       recipe: <
         name: "chromium"
         cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
@@ -7160,9 +7161,11 @@ buckets: <
       name: "linux-code-coverage"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
-      dimensions: "builder:linux-code-coverage"
+      dimensions: "builderless:1"
       dimensions: "cores:32"
       dimensions: "cpu:x86-64"
+      dimensions: "os:Ubuntu-16.04"
+      dimensions: "ssd:1"
       recipe: <
         name: "chromium"
         cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"