Revert "[Nearby] Use common default device name creation for Windows"
This reverts commit 45e983ef. Reason for revert: Seeing a build breakage on Windows (https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17509). Reverting just to be safe. Original change's description: > [Nearby] Use common default device name creation for Windows > > We previously handled default device name creation for Windows > differently than we did for other non-Chrome OS platforms. The > underlying reason appears to be that the Nearby Share service unit tests > were using base::RunLoop().RunUntilIdle() instead of > task_environment_.RunUntilIdle(). Because the hardware info fetch takes > longer on Windows than other platforms, I suspect that was the reason > only Windows was having issues. The correct run loop behavior was fixed > in a previous CL. > > Fixed: 1127603 > Change-Id: I1f10027696fb47d30ccfe0aa7b2ceb7c85de1393 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407856 > Auto-Submit: Josh Nohle <nohle@chromium.org> > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#806466} TBR=nohle@chromium.org,vecore@google.com Change-Id: Ieafb3f36869b1e2dc0a1db70a379d51f85a67b79 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407335Reviewed-by:Josh Nohle <nohle@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#806467}
Showing
Please register or sign in to comment