Commit f8f05d06 authored by Paul Miller's avatar Paul Miller Committed by Commit Bot

WebView: Report test experiment via logcat

This is for testing purposes and will be removed after launching
variations in WebView: https://crbug.com/841623. Skipping presubmit for
LOG(INFO).

BUG=678288
NOPRESUBMIT=true

Change-Id: Ia100eb88a20b3155ef8d280e598644b3684990a0
Reviewed-on: https://chromium-review.googlesource.com/1053375Reviewed-by: default avatarChangwan Ryu <changwan@chromium.org>
Reviewed-by: default avatarBo <boliu@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557593}
parent 57552aeb
...@@ -37,6 +37,19 @@ CreateLowEntropyProvider(const std::string& client_id) { ...@@ -37,6 +37,19 @@ CreateLowEntropyProvider(const std::string& client_id) {
new variations::SHA1EntropyProvider(client_id)); new variations::SHA1EntropyProvider(client_id));
} }
// This experiment is for testing and doesn't control any features. Log it so QA
// can check whether variations is working.
// TODO(crbug/841623): Remove this after launch.
void LogTestExperiment() {
static const char* const test_name = "First-WebView-Experiment";
base::FieldTrial* test_trial = base::FieldTrialList::Find(test_name);
if (test_trial) {
LOG(INFO) << test_name << " found, group=" << test_trial->group_name();
} else {
LOG(INFO) << test_name << " not found";
}
}
} // anonymous namespace } // anonymous namespace
AwFieldTrialCreator::AwFieldTrialCreator() AwFieldTrialCreator::AwFieldTrialCreator()
...@@ -108,6 +121,8 @@ void AwFieldTrialCreator::SetUpFieldTrials() { ...@@ -108,6 +121,8 @@ void AwFieldTrialCreator::SetUpFieldTrials() {
std::vector<std::string>(), CreateLowEntropyProvider(client_id), std::vector<std::string>(), CreateLowEntropyProvider(client_id),
std::make_unique<base::FeatureList>(), aw_field_trials_.get(), std::make_unique<base::FeatureList>(), aw_field_trials_.get(),
&ignored_safe_seed_manager); &ignored_safe_seed_manager);
LogTestExperiment();
} }
} // namespace android_webview } // namespace android_webview
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment