Commit f948f745 authored by Daniel Classon's avatar Daniel Classon Committed by Commit Bot

[PrintingPage] Renames the Cups Printer tests for clarity

Renames the Cups Printer tests to reflect that they work with the
cups_printer.html page. This helps with deep linking by making room
for a test for the actual os_printing_page.

Bug: 1084154
Change-Id: Ia2884b16bf488f0079e781191452826b4d606fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391509Reviewed-by: default avatarJimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/master@{#804039}
parent d228c2e0
...@@ -1445,7 +1445,7 @@ GEN('#endif'); ...@@ -1445,7 +1445,7 @@ GEN('#endif');
// Tests for the CUPS printer entry. // Tests for the CUPS printer entry.
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
var OSSettingsPrinterEntryTest = class extends OSSettingsBrowserTest { var OSSettingsCupsPrinterEntryTest = class extends OSSettingsBrowserTest {
/** @override */ /** @override */
get browsePreload() { get browsePreload() {
return super.browsePreload + return super.browsePreload +
...@@ -1463,13 +1463,13 @@ var OSSettingsPrinterEntryTest = class extends OSSettingsBrowserTest { ...@@ -1463,13 +1463,13 @@ var OSSettingsPrinterEntryTest = class extends OSSettingsBrowserTest {
} }
}; };
TEST_F('OSSettingsPrinterEntryTest', 'AllJsTests', () => { TEST_F('OSSettingsCupsPrinterEntryTest', 'AllJsTests', () => {
mocha.run(); mocha.run();
}); });
// Tests for the CUPS printer landing page. // Tests for the CUPS printer landing page.
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
var OSSettingsPrinterLandingPageTest = class extends OSSettingsBrowserTest { var OSSettingsCupsPrinterLandingPageTest = class extends OSSettingsBrowserTest {
/** @override */ /** @override */
get browsePreload() { get browsePreload() {
return super.browsePreload + 'chromeos/os_printing_page/cups_printers.html'; return super.browsePreload + 'chromeos/os_printing_page/cups_printers.html';
...@@ -1491,13 +1491,13 @@ var OSSettingsPrinterLandingPageTest = class extends OSSettingsBrowserTest { ...@@ -1491,13 +1491,13 @@ var OSSettingsPrinterLandingPageTest = class extends OSSettingsBrowserTest {
} }
}; };
TEST_F('OSSettingsPrinterLandingPageTest', 'AllJsTests', () => { TEST_F('OSSettingsCupsPrinterLandingPageTest', 'AllJsTests', () => {
mocha.run(); mocha.run();
}); });
// Tests for the CUPS page. // Tests for the CUPS page, primarily the (edit/add) dialogs.
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
var OSSettingsPrintingPageTest = class extends OSSettingsBrowserTest { var OSSettingsCupsPrinterPageTest = class extends OSSettingsBrowserTest {
/** @override */ /** @override */
get browsePreload() { get browsePreload() {
return super.browsePreload + 'chromeos/os_printing_page/cups_printers.html'; return super.browsePreload + 'chromeos/os_printing_page/cups_printers.html';
...@@ -1523,7 +1523,7 @@ var OSSettingsPrintingPageTest = class extends OSSettingsBrowserTest { ...@@ -1523,7 +1523,7 @@ var OSSettingsPrintingPageTest = class extends OSSettingsBrowserTest {
} }
}; };
TEST_F('OSSettingsPrintingPageTest', 'AllJsTests', () => { TEST_F('OSSettingsCupsPrinterPageTest', 'AllJsTests', () => {
mocha.run(); mocha.run();
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment