Use let/const in ui/file_manager/file_manager/test.

Following errors by eslint are not automatically fixed.
I fixed these manually.
(Used eslint-disable-next-line for redefining global object.)

/ui/file_manager/file_manager/test/js/chrome_api_test_impl.js
   13:1  error  Unexpected var, use let or const instead  no-var
  152:9  error  Unexpected var, use let or const instead  no-var
/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
  283:1  error  Unexpected var, use let or const instead  no-var
/ui/file_manager/file_manager/test/js/test_util.js
    8:1  error  Unexpected var, use let or const instead  no-var
  376:3  error  Unexpected var, use let or const instead  no-var

Bug: 778674
Test: Run browser_tests/closure_compiler
Change-Id: Ifeccd95fd0c459c5752855ef7f218d646bd6c6ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014600
Commit-Queue: Noel Gordon <noel@chromium.org>
Auto-Submit: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734146}

ui/file_manager/file_manager/test/crostini_tasks.js

@@ -11,7 +11,7 @@ crostiniTasks.testErrorLoadingLinuxPackageInfo = async (done) => {
 
   // Save old fmp.getFileTasks and replace with version that returns
   // the internal linux package install handler
-  let oldGetFileTasks = chrome.fileManagerPrivate.getFileTasks;
+  const oldGetFileTasks = chrome.fileManagerPrivate.getFileTasks;
   chrome.fileManagerPrivate.getFileTasks = (entries, callback) => {
     setTimeout(
         callback, 0, [{
@@ -24,7 +24,7 @@ crostiniTasks.testErrorLoadingLinuxPackageInfo = async (done) => {
 
   // Save old fmp.getLinuxPackageInfo and replace with version that saves the
   // callback to manually call later
-  let oldGetLinuxPackageInfo = chrome.fileManagerPrivate.getLinuxPackageInfo;
+  const oldGetLinuxPackageInfo = chrome.fileManagerPrivate.getLinuxPackageInfo;
   let packageInfoCallback = null;
   chrome.fileManagerPrivate.getLinuxPackageInfo = (entry, callback) => {
     packageInfoCallback = callback;

ui/file_manager/file_manager/test/js/chrome_api_test_impl.js

@@ -10,6 +10,7 @@
  */
 
 // All testing functions in namespace 'test'.
+// eslint-disable-next-line
 var test = test || {};
 
 test.Event = class {
@@ -30,7 +31,7 @@ test.Event = class {
   /** @param {...*} args */
   dispatchEvent(...args) {
     setTimeout(() => {
-      for (let listener of this.listeners_) {
+      for (const listener of this.listeners_) {
         listener(...args);
       }
     }, 0);
@@ -149,9 +150,9 @@ chrome = {
     state_: {},
     local: {
       get: (keys, callback) => {
-        var keys = keys instanceof Array ? keys : [keys];
-        var result = {};
-        keys.forEach(key => {
+        const inKeys = keys instanceof Array ? keys : [keys];
+        const result = {};
+        inKeys.forEach(key => {
           if (key in chrome.storage.state_) {
             result[key] = chrome.storage.state_[key];
           }
@@ -159,7 +160,7 @@ chrome = {
         setTimeout(callback, 0, result);
       },
       set: (items, opt_callback) => {
-        for (var key in items) {
+        for (const key in items) {
           chrome.storage.state_[key] = items[key];
         }
         if (opt_callback) {

ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js

@@ -79,9 +79,9 @@ chrome.fileManagerPrivate = {
   },
   getEntryProperties: (entries, names, callback) => {
     // Returns chrome.fileManagerPrivate.EntryProperties[].
-    var results = [];
+    const results = [];
     entries.forEach(entry => {
-      var props = {};
+      const props = {};
       names.forEach(name => {
         props[name] = entry.metadata[name];
       });
@@ -91,7 +91,7 @@ chrome.fileManagerPrivate = {
   },
   getFileTasks: (entries, callback) => {
     // Returns chrome.fileManagerPrivate.FileTask[].
-    var results = [];
+    const results = [];
     // Support for view-in-browser on single text file used by QuickView.
     if (entries.length == 1 && entries[0].metadata &&
         entries[0].metadata.contentMimeType == 'text/plain') {
@@ -142,8 +142,8 @@ chrome.fileManagerPrivate = {
     setTimeout(callback, 0, loadTimeData.data_);
   },
   getVolumeMetadataList: (callback) => {
-    var list = [];
-    for (var i = 0; i < mockVolumeManager.volumeInfoList.length; i++) {
+    const list = [];
+    for (let i = 0; i < mockVolumeManager.volumeInfoList.length; i++) {
       list.push(mockVolumeManager.volumeInfoList.item(i));
     }
     setTimeout(callback, 0, list);
@@ -205,7 +205,7 @@ chrome.fileManagerPrivate = {
   nextCopyId_: 0,
   startCopy: (entry, parentEntry, newName, callback) => {
     // Returns copyId immediately.
-    var copyId = chrome.fileManagerPrivate.nextCopyId_++;
+    const copyId = chrome.fileManagerPrivate.nextCopyId_++;
     callback(copyId);
     chrome.fileManagerPrivate.onCopyProgress.listeners_.forEach(l => {
       l(copyId, {type: 'begin_copy_entry', sourceUrl: entry.toURL()});
@@ -280,16 +280,17 @@ chrome.fileSystem = {
  * @param {function(!MockEntry)} successCallback Success callback.
  * @param {function(!Error)} errorCallback Error callback.
  */
+// eslint-disable-next-line
 var webkitResolveLocalFileSystemURL = (url, successCallback, errorCallback) => {
-  var match = url.match(/^filesystem:(\w+)(\/.*)/);
+  const match = url.match(/^filesystem:(\w+)(\/.*)/);
   if (match) {
-    var volumeType = /** @type {VolumeManagerCommon.VolumeType} */ (match[1]);
-    var path = match[2];
-    var volume = mockVolumeManager.getCurrentProfileVolumeInfo(volumeType);
+    const volumeType = /** @type {VolumeManagerCommon.VolumeType} */ (match[1]);
+    let path = match[2];
+    const volume = mockVolumeManager.getCurrentProfileVolumeInfo(volumeType);
     if (volume) {
       // Decode URI in file paths.
       path = path.split('/').map(decodeURIComponent).join('/');
-      var entry = volume.fileSystem.entries[path];
+      const entry = volume.fileSystem.entries[path];
       if (entry) {
         setTimeout(successCallback, 0, entry);
         return;

ui/file_manager/file_manager/test/js/test_util.js

@@ -5,6 +5,7 @@
 'use strict';
 
 // All testing functions in namespace 'test'.
+// eslint-disable-next-line
 var test = test || {};
 
 // Update paths for testing.
@@ -31,7 +32,7 @@ test.DATA = {
 test.loadData = function() {
   return Promise.all(Object.keys(test.DATA).map(filename => {
     return new Promise(resolve => {
-      var req = new XMLHttpRequest();
+      const req = new XMLHttpRequest();
       req.responseType = 'blob';
       req.onload = () => {
         test.DATA[filename] = req.response;
@@ -342,10 +343,10 @@ test.REPEAT_UNTIL_LOG_INTERVAL = 3000;
  *     pending.
  */
 test.pending = function(message, var_args) {
-  var index = 1;
-  var args = arguments;
-  var formattedMessage = message.replace(/%[sdj]/g, function(pattern) {
-    var arg = args[index++];
+  let index = 1;
+  const args = arguments;
+  const formattedMessage = message.replace(/%[sdj]/g, function(pattern) {
+    const arg = args[index++];
     switch (pattern) {
       case '%s':
         return String(arg);
@@ -357,7 +358,7 @@ test.pending = function(message, var_args) {
         return pattern;
     }
   });
-  var pendingMarker = Object.create(test.pending.prototype);
+  const pendingMarker = Object.create(test.pending.prototype);
   pendingMarker.message = formattedMessage;
   return pendingMarker;
 };
@@ -371,9 +372,9 @@ test.pending = function(message, var_args) {
  *     marker.
  */
 test.repeatUntil = function(checkFunction) {
-  var logTime = Date.now() + test.REPEAT_UNTIL_LOG_INTERVAL;
-  var loopCount = 0;
-  var step = function() {
+  let logTime = Date.now() + test.REPEAT_UNTIL_LOG_INTERVAL;
+  let loopCount = 0;
+  const step = function() {
     loopCount++;
     return Promise.resolve(checkFunction()).then(function(result) {
       if (!(result instanceof test.pending)) {
@@ -384,7 +385,7 @@ test.repeatUntil = function(checkFunction) {
         logTime += test.REPEAT_UNTIL_LOG_INTERVAL;
       }
       // Repeat immediately for the first few, then wait between repeats.
-      var interval = loopCount <= test.REPEAT_UNTIL_IMMEDIATE_COUNT ?
+      const interval = loopCount <= test.REPEAT_UNTIL_IMMEDIATE_COUNT ?
           0 :
           test.REPEAT_UNTIL_INTERVAL;
       return new Promise(resolve => {
@@ -403,7 +404,7 @@ test.repeatUntil = function(checkFunction) {
  */
 test.waitForElement = function(query) {
   return test.repeatUntil(() => {
-    let element = document.querySelector(query);
+    const element = document.querySelector(query);
     if (element) {
       return element;
     }
@@ -418,7 +419,7 @@ test.waitForElement = function(query) {
  */
 test.waitForElementLost = function(query) {
   return test.repeatUntil(() => {
-    var element = document.querySelector(query);
+    const element = document.querySelector(query);
     if (element) {
       return test.pending('Elements %s still exists.', query);
     }
@@ -528,10 +529,10 @@ test.mountAndroidFiles = function() {
  *     given contents.
  */
 test.waitForFiles = function(expected, opt_options) {
-  var options = opt_options || {};
-  var nextLog = Date.now() + test.REPEAT_UNTIL_LOG_INTERVAL;
+  const options = opt_options || {};
+  let nextLog = Date.now() + test.REPEAT_UNTIL_LOG_INTERVAL;
   return test.repeatUntil(function() {
-    var files = test.getFileList();
+    const files = test.getFileList();
     if (Date.now() > nextLog) {
       console.debug('waitForFiles', expected, files);
       nextLog = Date.now() + test.REPEAT_UNTIL_LOG_INTERVAL;
@@ -545,7 +546,7 @@ test.waitForFiles = function(expected, opt_options) {
           if (a.length != b.length) {
             return false;
           }
-          for (var i = 0; i < files.length; i++) {
+          for (let i = 0; i < files.length; i++) {
             // Each row is [name, size, type, date].
             if ((!options.ignoreName && a[i][0] != b[i][0]) ||
                 (!options.ignoreSize && a[i][1] != b[i][1]) ||

ui/file_manager/file_manager/test/progress_center.js

@@ -10,7 +10,7 @@ const progressCenter = {};
  * @return {!ProgressCenterItem}
  */
 progressCenter.createItem = function(id, message) {
-  let item = new ProgressCenterItem();
+  const item = new ProgressCenterItem();
   item.id = id;
   item.message = message;
   return item;