Commit f95d90e3 authored by David Roger's avatar David Roger Committed by Chromium LUCI CQ

[profiles] Update title for profile deletion confirmation dialog

Local profile:
https://drive.google.com/file/d/1GH_DmqD-A0bVU-ebZND96-vGN5ao7_fZ/view?usp=sharing&resourcekey=0-WGPrVjdN2hJcXBJ7YVwE2w

Signedin profile:
https://drive.google.com/file/d/1cK0pYOunr_j6sS84bgJDlC6-6fi_WyRJ/view?usp=sharing&resourcekey=0-o_2bkNB9RiJtxxTVAWDOSQ

Fixed: 1166653
Change-Id: I46365046e2a940951088f77367a4cb47ded0d1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628295
Auto-Submit: David Roger <droger@chromium.org>
Reviewed-by: default avatarAlex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843557}
parent d709a1a4
...@@ -138,8 +138,7 @@ ...@@ -138,8 +138,7 @@
<cr-dialog id="removeConfirmationDialog" ignore-enter-key> <cr-dialog id="removeConfirmationDialog" ignore-enter-key>
<div slot="title"> <div slot="title">
$i18n{profileMenuRemoveText} [[removeWarningTitle_]]
<span class="key-text">[[profileState.localProfileName]]</span>
</div> </div>
<div id="removeWarningHeader" slot="header" class="warning-message"> <div id="removeWarningHeader" slot="header" class="warning-message">
[[removeWarningText_]] [[removeWarningText_]]
......
...@@ -93,6 +93,12 @@ Polymer({ ...@@ -93,6 +93,12 @@ Polymer({
type: String, type: String,
computed: 'computeRemoveWarningText_(profileState)', computed: 'computeRemoveWarningText_(profileState)',
}, },
/** @private */
removeWarningTitle_: {
type: String,
computed: 'computeRemoveWarningTitle_(profileState)',
},
}, },
/** @private {ManageProfilesBrowserProxy} */ /** @private {ManageProfilesBrowserProxy} */
...@@ -125,6 +131,16 @@ Polymer({ ...@@ -125,6 +131,16 @@ Polymer({
'removeWarningLocalProfile'); 'removeWarningLocalProfile');
}, },
/**
* @return {string}
* @private
*/
computeRemoveWarningTitle_() {
return this.i18n(
this.profileState.isSyncing ? 'removeWarningSignedInProfileTitle' :
'removeWarningLocalProfileTitle');
},
/** /**
* @param {!Event} e * @param {!Event} e
* @private * @private
......
...@@ -90,8 +90,12 @@ void AddStrings(content::WebUIDataSource* html_source) { ...@@ -90,8 +90,12 @@ void AddStrings(content::WebUIDataSource* html_source) {
IDS_PROFILE_PICKER_PROFILE_MENU_CUSTOMIZE_TEXT}, IDS_PROFILE_PICKER_PROFILE_MENU_CUSTOMIZE_TEXT},
{"removeWarningLocalProfile", {"removeWarningLocalProfile",
IDS_PROFILE_PICKER_REMOVE_WARNING_LOCAL_PROFILE}, IDS_PROFILE_PICKER_REMOVE_WARNING_LOCAL_PROFILE},
{"removeWarningLocalProfileTitle",
IDS_PROFILE_PICKER_REMOVE_WARNING_LOCAL_PROFILE_TITLE},
{"removeWarningSignedInProfile", {"removeWarningSignedInProfile",
IDS_PROFILE_PICKER_REMOVE_WARNING_SIGNED_IN_PROFILE}, IDS_PROFILE_PICKER_REMOVE_WARNING_SIGNED_IN_PROFILE},
{"removeWarningSignedInProfileTitle",
IDS_PROFILE_PICKER_REMOVE_WARNING_SIGNED_IN_PROFILE_TITLE},
{"removeWarningHistory", IDS_PROFILE_PICKER_REMOVE_WARNING_HISTORY}, {"removeWarningHistory", IDS_PROFILE_PICKER_REMOVE_WARNING_HISTORY},
{"removeWarningPasswords", IDS_PROFILE_PICKER_REMOVE_WARNING_PASSWORDS}, {"removeWarningPasswords", IDS_PROFILE_PICKER_REMOVE_WARNING_PASSWORDS},
{"removeWarningBookmarks", IDS_PROFILE_PICKER_REMOVE_WARNING_BOOKMARKS}, {"removeWarningBookmarks", IDS_PROFILE_PICKER_REMOVE_WARNING_BOOKMARKS},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment