Commit f985560e authored by danakj's avatar danakj Committed by Commit Bot

Use LOG instead of DLOG for crash logging in web tests.

Clusterfuzz doesn't always enable DCHECKs and using DLOG prevents us
from seeing which process type crashed.

The Clusterfuzz reports don't include logging from the child process
to display the stack trace either so this is important.

R=nasko@chromium.org

Bug: 1068300
Change-Id: If2b7c676ff314e53af5877dbbd5ca0508cc9d920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140299Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757156}
parent eabaf8df
......@@ -141,10 +141,10 @@ void CreateChildProcessCrashWatcher() {
const ChildProcessData& data,
const ChildProcessTerminationInfo& info) override {
// Child processes should not crash in web tests.
DLOG(ERROR) << "Child process crashed with\n"
" process_type: "
<< data.process_type << "\n"
<< " name: " << data.name;
LOG(ERROR) << "Child process crashed with\n"
" process_type: "
<< data.process_type << "\n"
<< " name: " << data.name;
CHECK(false);
}
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment