Commit f9c01aee authored by dougarnett's avatar dougarnett Committed by Commit bot

[Offline Pages] Simple, mergable fix to no longer report a request completed...

[Offline Pages] Simple, mergable fix to no longer report a request completed when it is FOREGROUND_CANCELED or PRERENDERING_CANCELED and subject to retry.

BUG=644444

Review-Url: https://codereview.chromium.org/2326593002
Cr-Commit-Position: refs/heads/master@{#417328}
parent b18a04f5
...@@ -492,11 +492,7 @@ void RequestCoordinator::OfflinerDoneCallback(const SavePageRequest& request, ...@@ -492,11 +492,7 @@ void RequestCoordinator::OfflinerDoneCallback(const SavePageRequest& request,
// aborted cases to treat this way (eg, for Render Process Killed). // aborted cases to treat this way (eg, for Render Process Killed).
SavePageRequest updated_request(request); SavePageRequest updated_request(request);
AbortRequestAttempt(&updated_request); AbortRequestAttempt(&updated_request);
BackgroundSavePageResult notify_status = NotifyChanged(updated_request);
(status == Offliner::RequestStatus::FOREGROUND_CANCELED)
? BackgroundSavePageResult::FOREGROUND_CANCELED
: BackgroundSavePageResult::PRERENDER_CANCELED;
NotifyCompleted(updated_request, notify_status);
} else if (status == Offliner::RequestStatus::SAVED) { } else if (status == Offliner::RequestStatus::SAVED) {
// Remove the request from the queue if it succeeded. // Remove the request from the queue if it succeeded.
RemoveAttemptedRequest(request, BackgroundSavePageResult::SUCCESS); RemoveAttemptedRequest(request, BackgroundSavePageResult::SUCCESS);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment