WebIDL Dictionaries should access prototype chains when searching for...

WebIDL Dictionaries should access prototype chains when searching for properties. This change adds getPropertyNames to the v8 Dictionary class.

Web Animations Keyframes should make use of prototype chains when looking for CSS properties to animate. This change makes use of getPropertyNames to ensure this happens.

Review URL: https://codereview.chromium.org/661453004

git-svn-id: svn://svn.chromium.org/blink/trunk@184350 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/web-animations-api/w3c/keyframe-properties.html

@@ -36,11 +36,10 @@ test(function() {
     value: '100px',
     enumerable: 'true'});
   var keyframe = new Keyframe();
-  assert_array_equals(Object.keys(keyframe), ["top"]);
   try {
-    div.animate([keyframe, {top: '200px'}], 1);
+    div.animate([keyframe, {top: '200px', left: '200px', height: '200px'}], 1);
   } catch (e) {
-    assert_unreached("Mismatched properties - left, width or height considered on keyframe.");
+    assert_unreached("Mismatched properties - left, width or height not considered on keyframe.");
   }
 },
 'inherited keyframe properties tests',

third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

@@ -264,6 +264,29 @@ bool Dictionary::getOwnPropertyNames(Vector<String>& names) const
     return true;
 }
 
+bool Dictionary::getPropertyNames(Vector<String>& names) const
+{
+    if (!isObject())
+        return false;
+
+    v8::Handle<v8::Object> options = m_options->ToObject();
+    if (options.IsEmpty())
+        return false;
+
+    v8::Local<v8::Array> properties = options->GetPropertyNames();
+    if (properties.IsEmpty())
+        return true;
+    for (uint32_t i = 0; i < properties->Length(); ++i) {
+        v8::Local<v8::String> key = properties->Get(i)->ToString();
+        if (!options->Has(key))
+            continue;
+        TOSTRING_DEFAULT(V8StringResource<>, stringKey, key, false);
+        names.append(stringKey);
+    }
+
+    return true;
+}
+
 void Dictionary::ConversionContext::resetPerPropertyContext()
 {
     if (m_dirty) {

third_party/WebKit/Source/bindings/core/v8/Dictionary.h

@@ -125,6 +125,7 @@ public:
 
     bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;
     bool getOwnPropertyNames(Vector<String>&) const;
+    bool getPropertyNames(Vector<String>&) const;
 
     bool getWithUndefinedOrNullCheck(const String&, String&) const;
     bool getWithUndefinedOrNullCheck(const String&, RefPtrWillBeMember<Element>&) const;

third_party/WebKit/Source/core/animation/EffectInput.cpp

@@ -95,7 +95,7 @@ PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, c
         }
 
         Vector<String> keyframeProperties;
-        keyframeDictionaryVector[i].getOwnPropertyNames(keyframeProperties);
+        keyframeDictionaryVector[i].getPropertyNames(keyframeProperties);
         for (size_t j = 0; j < keyframeProperties.size(); ++j) {
             String property = keyframeProperties[j];
             CSSPropertyID id = AnimationInputHelpers::keyframeAttributeToCSSPropertyID(property);