WebLayer: remove Tab#dismissTabModalOverlay

This API is of questionable utility given Tab#dismissTransientUi. It
was added in 82, so it can be removed in 82 without going through
deprecation.

If it's deemed useful in the future, it will be possible to add it back.

Change-Id: I553a42e44c36471ef7b236c584a98f09d38c5c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099763
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749735}

weblayer/browser/android/javatests/src/org/chromium/weblayer/test/TabCallbackTest.java

@@ -194,8 +194,8 @@ public class TabCallbackTest {
         Assert.assertEquals(true, isTabModalShowingResult[0]);
 
         callCount = callbackHelper.getCallCount();
-        TestThreadUtils.runOnUiThreadBlocking(
-                () -> { activity.getTab().dismissTabModalOverlay(); });
+        Assert.assertTrue(TestThreadUtils.runOnUiThreadBlockingNoException(
+                () -> activity.getTab().dismissTransientUi()));
         callbackHelper.waitForCallback(callCount);
         Assert.assertEquals(false, isTabModalShowingResult[0]);
     }

weblayer/browser/java/org/chromium/weblayer_private/TabImpl.java

@@ -416,12 +416,6 @@ public final class TabImpl extends ITab.Stub {
         }
     }
 
-    @Override
-    public void dismissTabModalOverlay() {
-        BrowserViewController controller = getViewController();
-        if (controller != null) controller.dismissTabModalOverlay();
-    }
-
     @Override
     public void dispatchBeforeUnloadAndClose() {
         StrictModeWorkaround.apply();

weblayer/browser/java/org/chromium/weblayer_private/interfaces/ITab.aidl

@@ -36,7 +36,8 @@ interface ITab {
   boolean setFindInPageCallbackClient(IFindInPageCallbackClient client) = 8;
   void findInPage(in String searchText, boolean forward) = 9;
 
-  void dismissTabModalOverlay() = 10;
+  // And and removed in 82; superseded by dismissTransientUi().
+  // void dismissTabModalOverlay() = 10;
   void dispatchBeforeUnloadAndClose() = 11;
 
   boolean dismissTransientUi() = 12;

weblayer/public/java/org/chromium/weblayer/Tab.java

@@ -194,28 +194,6 @@ public class Tab {
         }
     }
 
-    /**
-     * Dismisses the active tab modal overlay.
-     *
-     * If other tab modal dialogs are queued, they will then be shown. This has no effect if no tab
-     * modal dialog is currently displayed.
-     *
-     * See also {@link TabCallback#onTabModalStateChanged}.
-     *
-     * @since 82
-     */
-    public void dismissTabModalOverlay() {
-        ThreadCheck.ensureOnUiThread();
-        if (WebLayer.getSupportedMajorVersionInternal() < 82) {
-            throw new UnsupportedOperationException();
-        }
-        try {
-            mImpl.dismissTabModalOverlay();
-        } catch (RemoteException e) {
-            throw new APICallException(e);
-        }
-    }
-
     /**
      * Runs the beforeunload handler for the main frame or any sub frame, if necessary; otherwise,
      * asynchronously closes the tab.