Commit f9f94c91 authored by chengx's avatar chengx Committed by Commit bot

Fix the parsing error in tools/metrics/histograms/histograms.xml

tools\metrics\histograms/pretty_print.py fails to parse
tools/metrics/histograms/histograms.xml due to
1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult
2) ERROR:root:Unrecognized tag "obselete"

The failure of running pretty_print.py blocks uploading any CL
containing histograms.xml!

This CL removes DnsProbe.obsoleteProbeResult in three obsolete
histograms, and fixes "obselete" to "obsolete".

Running tools\metrics\histograms/pretty_print.py formats a few other
lines of code. This CL keeps this change.

BUG=725310

Review-Url: https://codereview.chromium.org/2896953002
Cr-Commit-Position: refs/heads/master@{#473900}
parent 07395f80
...@@ -13036,8 +13036,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. ...@@ -13036,8 +13036,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary> </summary>
</histogram> </histogram>
<histogram name="DnsProbe.Probe.NcnOffline.Result" <histogram name="DnsProbe.Probe.NcnOffline.Result">
enum="DnsProbe.ObsoleteProbeResult">
<obsolete> <obsolete>
Removed 7/2013. Removed 7/2013.
</obsolete> </obsolete>
...@@ -13057,8 +13056,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. ...@@ -13057,8 +13056,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary> </summary>
</histogram> </histogram>
<histogram name="DnsProbe.Probe.NcnOnline.Result" <histogram name="DnsProbe.Probe.NcnOnline.Result">
enum="DnsProbe.ObsoleteProbeResult">
<obsolete> <obsolete>
Removed 7/2013. Removed 7/2013.
</obsolete> </obsolete>
...@@ -13068,7 +13066,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. ...@@ -13068,7 +13066,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary> </summary>
</histogram> </histogram>
<histogram name="DnsProbe.Probe.Result" enum="DnsProbe.ObsoleteProbeResult"> <histogram name="DnsProbe.Probe.Result">
<obsolete> <obsolete>
Renamed 7/2013 to DnsProbe.ProbeResult. (Also switched to the full Renamed 7/2013 to DnsProbe.ProbeResult. (Also switched to the full
DnsProbe.ProbeStatus enum.) DnsProbe.ProbeStatus enum.)
...@@ -46403,9 +46401,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. ...@@ -46403,9 +46401,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Omnibox.ProgressBarBreakPointUpdateCount" <histogram name="Omnibox.ProgressBarBreakPointUpdateCount"
units="break point updates"> units="break point updates">
<obselete> <obsolete>
Obselete 05/16/2017. Data is unused (crbug.com/719801). Obselete 05/16/2017. Data is unused (crbug.com/719801).
</obselete> </obsolete>
<owner>kkimlabs@chromium.org</owner> <owner>kkimlabs@chromium.org</owner>
<summary> <summary>
The number of progress bar break point updates from page load started to The number of progress bar break point updates from page load started to
...@@ -46414,9 +46412,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. ...@@ -46414,9 +46412,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram> </histogram>
<histogram name="Omnibox.ProgressBarUpdateCount" units="frame updates"> <histogram name="Omnibox.ProgressBarUpdateCount" units="frame updates">
<obselete> <obsolete>
Obselete 05/16/2017. Data is unused (crbug.com/719801). Obselete 05/16/2017. Data is unused (crbug.com/719801).
</obselete> </obsolete>
<owner>kkimlabs@chromium.org</owner> <owner>kkimlabs@chromium.org</owner>
<summary> <summary>
The number of progress bar frame updates from page load started to page load The number of progress bar frame updates from page load started to page load
...@@ -72083,16 +72081,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. ...@@ -72083,16 +72081,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram base="true" name="Storage.BytesRead" units="bytes"> <histogram base="true" name="Storage.BytesRead" units="bytes">
<owner>michaeln@chromium.org</owner> <owner>michaeln@chromium.org</owner>
<summary> <summary>The number of bytes read. Recorded on each read.</summary>
The number of bytes read. Recorded on each read.
</summary>
</histogram> </histogram>
<histogram base="true" name="Storage.BytesWritten" units="bytes"> <histogram base="true" name="Storage.BytesWritten" units="bytes">
<owner>michaeln@chromium.org</owner> <owner>michaeln@chromium.org</owner>
<summary> <summary>The number of bytes written. Recorded on each write.</summary>
The number of bytes written. Recorded on each write.
</summary>
</histogram> </histogram>
<histogram name="Storage.ImportantSites.CBDChosenReason" <histogram name="Storage.ImportantSites.CBDChosenReason"
...@@ -82167,8 +82161,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. ...@@ -82167,8 +82161,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<owner>philipel@chromium.org</owner> <owner>philipel@chromium.org</owner>
<summary> <summary>
A successful probing attempt for a given bitrate, triggered by an update to A successful probing attempt for a given bitrate, triggered by an update to
the max configured bitrate. NOTE! This is not the resulting bitrate from the max configured bitrate. NOTE! This is not the resulting bitrate from a
a probing attempt, see WebRTC.BWE.MidCallProbing.ProbedKbps. probing attempt, see WebRTC.BWE.MidCallProbing.ProbedKbps.
</summary> </summary>
</histogram> </histogram>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment