Commit fa11ee35 authored by David Van Cleve's avatar David Van Cleve Committed by Chromium LUCI CQ

[Sheriff] Disable PageAdDensityIgnoreDisplayNoneFrame (flakes)

This test has been failing intermittently recently. Flake Portal link:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyawsSBUZsYWtlImBjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEFkc1BhZ2VMb2FkTWV0cmljc09ic2VydmVyQnJvd3NlclRlc3QuUGFnZUFkRGVuc2l0eUlnbm9yZURpc3BsYXlOb25lRnJhbWUM

It's already been disabled on Windows, but it's been failing on other
platforms, too.

I've added a few labels to the linked bug to help track.

R=johnidel

Bug: 1121444
Change-Id: I5ab328a6967437203c6390f71e6fe13f5c24eb81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631192
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: default avatarJohn Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843870}
parent e14afad2
...@@ -494,15 +494,11 @@ IN_PROC_BROWSER_TEST_F(AdsPageLoadMetricsObserverBrowserTest, ...@@ -494,15 +494,11 @@ IN_PROC_BROWSER_TEST_F(AdsPageLoadMetricsObserverBrowserTest,
// Creates a frame with display:none styling and verifies that it has an // Creates a frame with display:none styling and verifies that it has an
// empty intersection with the main frame. // empty intersection with the main frame.
#if defined(OS_WIN) //
#define MAYBE_PageAdDensityIgnoreDisplayNoneFrame \ // TODO(crbug.com/1121444): This test is disabled due to flaky failures on
DISABLED_PageAdDensityIgnoreDisplayNoneFrame // multiple platforms.
#else
#define MAYBE_PageAdDensityIgnoreDisplayNoneFrame \
PageAdDensityIgnoreDisplayNoneFrame
#endif
IN_PROC_BROWSER_TEST_F(AdsPageLoadMetricsObserverBrowserTest, IN_PROC_BROWSER_TEST_F(AdsPageLoadMetricsObserverBrowserTest,
MAYBE_PageAdDensityIgnoreDisplayNoneFrame) { DISABLED_PageAdDensityIgnoreDisplayNoneFrame) {
base::HistogramTester histogram_tester; base::HistogramTester histogram_tester;
ukm::TestAutoSetUkmRecorder ukm_recorder; ukm::TestAutoSetUkmRecorder ukm_recorder;
auto waiter = CreatePageLoadMetricsTestWaiter(); auto waiter = CreatePageLoadMetricsTestWaiter();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment