Commit fa476237 authored by Abhijeet Kandalkar's avatar Abhijeet Kandalkar Committed by Commit Bot

Add to_snake_case function in make_instrumenting_probes.py

The primary motivation is that the data member names are not following
proper naming conventions within probe_sink.h.tmpl and
instrumenting_probes_impl.cc.tmpl.

This CL add to_snake_case function in make_instrumenting_probes.py to
convert data members to snake case format.

Bug: 936684
Change-Id: I9934aec12dfd85094335078f7c1784f56d6aafac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524801
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641094}
parent e91cd380
...@@ -46,8 +46,8 @@ def to_singular(text): ...@@ -46,8 +46,8 @@ def to_singular(text):
return text[:-1] if text[-1] == "s" else text return text[:-1] if text[-1] == "s" else text
def to_lower_case(name): def to_snake_case(name):
return name[:1].lower() + name[1:] return NameStyleConverter(name).to_snake_case()
def agent_config(config, agent_name, field): def agent_config(config, agent_name, field):
...@@ -74,7 +74,7 @@ def initialize_jinja_env(config, cache_dir): ...@@ -74,7 +74,7 @@ def initialize_jinja_env(config, cache_dir):
lstrip_blocks=True, # so can indent control flow tags lstrip_blocks=True, # so can indent control flow tags
trim_blocks=True) trim_blocks=True)
jinja_env.filters.update({ jinja_env.filters.update({
"to_lower_case": to_lower_case, "to_snake_case": to_snake_case,
"to_singular": to_singular, "to_singular": to_singular,
"agent_name_to_class": partial(agent_name_to_class, config), "agent_name_to_class": partial(agent_name_to_class, config),
"agent_name_to_include": partial(agent_name_to_include, config)}) "agent_name_to_include": partial(agent_name_to_include, config)})
......
...@@ -42,7 +42,7 @@ std::atomic<unsigned> {{sink_class}}::s_existingAgents; ...@@ -42,7 +42,7 @@ std::atomic<unsigned> {{sink_class}}::s_existingAgents;
{% for agent in agents %} {% for agent in agents %}
{% set class_name = agent | agent_name_to_class %} {% set class_name = agent | agent_name_to_class %}
{% set getter_name = agent | to_lower_case %} {% set getter_name = agent | to_snake_case %}
// static // static
unsigned {{sink_class}}::s_numSinksWith{{agent}} = 0; unsigned {{sink_class}}::s_numSinksWith{{agent}} = 0;
...@@ -81,7 +81,7 @@ void {{sink_class}}::Remove{{agent}}({{class_name}}* agent) { ...@@ -81,7 +81,7 @@ void {{sink_class}}::Remove{{agent}}({{class_name}}* agent) {
void {{sink_class}}::Trace(Visitor* visitor) void {{sink_class}}::Trace(Visitor* visitor)
{ {
{% for agent in agents %} {% for agent in agents %}
{% set getter_name = agent | to_lower_case %} {% set getter_name = agent | to_snake_case %}
visitor->Trace({{getter_name}}s_); visitor->Trace({{getter_name}}s_);
{% endfor %} {% endfor %}
} }
......
...@@ -41,7 +41,7 @@ class {{export_symbol}} {{sink_class}} : public GarbageCollectedFinalized<{{sink ...@@ -41,7 +41,7 @@ class {{export_symbol}} {{sink_class}} : public GarbageCollectedFinalized<{{sink
{% for agent in agents %} {% for agent in agents %}
{% set class_name = agent | agent_name_to_class %} {% set class_name = agent | agent_name_to_class %}
{% set getter_name = agent | to_lower_case %} {% set getter_name = agent | to_snake_case %}
bool Has{{agent}}s() const { return !{{getter_name}}s_.IsEmpty(); } bool Has{{agent}}s() const { return !{{getter_name}}s_.IsEmpty(); }
const HeapListHashSet<Member<{{class_name}}>>& {{class_name}}s() const { return {{getter_name}}s_; } const HeapListHashSet<Member<{{class_name}}>>& {{class_name}}s() const { return {{getter_name}}s_; }
void Add{{agent}}({{class_name}}* agent); void Add{{agent}}({{class_name}}* agent);
...@@ -56,7 +56,7 @@ class {{export_symbol}} {{sink_class}} : public GarbageCollectedFinalized<{{sink ...@@ -56,7 +56,7 @@ class {{export_symbol}} {{sink_class}} : public GarbageCollectedFinalized<{{sink
private: private:
{% for agent in agents %} {% for agent in agents %}
{% set class_name = agent | agent_name_to_class %} {% set class_name = agent | agent_name_to_class %}
{% set getter_name = agent | to_lower_case %} {% set getter_name = agent | to_snake_case %}
HeapListHashSet<Member<{{class_name}}>> {{getter_name}}s_; HeapListHashSet<Member<{{class_name}}>> {{getter_name}}s_;
{% endfor %} {% endfor %}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment