Removed unused functions in autofill's form_data.cc.

Removed

autofill: :DeserializeFormDataFromBase64String()
autofill: :SerializeFormDataToBase64String()
Change-Id: Id393ecde0d134d9d03836ec1c6be0c053ef1bf43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824082Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#700159}

components/autofill/core/common/form_data.cc

@@ -155,15 +155,6 @@ void SerializeFormData(const FormData& form_data, base::Pickle* pickle) {
   pickle->WriteString(form_data.main_frame_origin.Serialize());
 }
 
-void SerializeFormDataToBase64String(const FormData& form_data,
-                                     std::string* output) {
-  base::Pickle pickle;
-  SerializeFormData(form_data, &pickle);
-  Base64Encode(
-      base::StringPiece(static_cast<const char*>(pickle.data()), pickle.size()),
-      output);
-}
-
 bool DeserializeFormData(base::PickleIterator* iter, FormData* form_data) {
   int version;
   FormData temp_form_data;
@@ -227,17 +218,6 @@ bool DeserializeFormData(base::PickleIterator* iter, FormData* form_data) {
   return true;
 }
 
-bool DeserializeFormDataFromBase64String(const base::StringPiece& input,
-                                         FormData* form_data) {
-  if (input.empty())
-    return false;
-  std::string pickle_data;
-  Base64Decode(input, &pickle_data);
-  base::Pickle pickle(pickle_data.data(), static_cast<int>(pickle_data.size()));
-  base::PickleIterator iter(pickle);
-  return DeserializeFormData(&iter, form_data);
-}
-
 LogBuffer& operator<<(LogBuffer& buffer, const FormData& form) {
   buffer << Tag{"div"} << Attrib{"class", "form"};
   buffer << Tag{"table"};

components/autofill/core/common/form_data.h

@@ -118,15 +118,6 @@ void SerializeFormData(const FormData& form_data, base::Pickle* pickle);
 // the part of a pickle created by SerializeFormData. Returns true on success.
 bool DeserializeFormData(base::PickleIterator* iter, FormData* form_data);
 
-// Serialize FormData. Used by the PasswordManager to persist FormData
-// pertaining to password forms in base64 string. It is useful since in some
-// cases we need to store C strings without embedded '\0' symbols.
-void SerializeFormDataToBase64String(const FormData& form_data,
-                                     std::string* output);
-// Deserialize FormData. Returns true on success.
-bool DeserializeFormDataFromBase64String(const base::StringPiece& input,
-                                         FormData* form_data);
-
 LogBuffer& operator<<(LogBuffer& buffer, const FormData& form);
 
 }  // namespace autofill

components/autofill/core/common/form_data_unittest.cc

@@ -121,7 +121,7 @@ void FillInDummyFormData(FormData* data) {
   data->action = GURL("https://example.com/action");
   data->main_frame_origin =
       url::Origin::Create(GURL("https://origin-example.com"));
-  data->is_form_tag = true;  // Default value.
+  data->is_form_tag = true;            // Default value.
   data->is_formless_checkout = false;  // Default value.
 
   FormFieldData field_data;
@@ -166,20 +166,6 @@ TEST(FormDataTest, SerializeAndDeserialize) {
   EXPECT_TRUE(actual.SameFormAs(data));
 }
 
-TEST(FormDataTest, SerializeAndDeserializeInStrings) {
-  FormData data;
-  FillInDummyFormData(&data);
-  data.is_form_tag = false;
-
-  std::string serialized_data;
-  SerializeFormDataToBase64String(data, &serialized_data);
-
-  FormData actual;
-  EXPECT_TRUE(DeserializeFormDataFromBase64String(serialized_data, &actual));
-
-  EXPECT_TRUE(actual.SameFormAs(data));
-}
-
 TEST(FormDataTest, Serialize_v1_Deserialize_vCurrent) {
   FormData data;
   FillInDummyFormData(&data);