Commit fa82758e authored by Jimmy Gong's avatar Jimmy Gong Committed by Commit Bot

Replace printer queue placeholder with a value in manual printers

- Fixes a bug where the default text for printer queue would appear
  grey, which made it seem inactive.

Bug: 958740
Test: end to end manual, browsertests
Change-Id: I18bdcc5a6984f737cabfaa7ab06a7714b5176194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663075Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Reviewed-by: default avatarSean Kau <skau@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671488}
parent 1b2010b9
...@@ -134,7 +134,7 @@ ...@@ -134,7 +134,7 @@
</div> </div>
</div> </div>
<div class="settings-box two-line"> <div class="settings-box two-line">
<cr-input placeholder="ipp/print" label="$i18n{printerQueue}" <cr-input label="$i18n{printerQueue}"
value="{{newPrinter.printerQueue}}" maxlength=64> value="{{newPrinter.printerQueue}}" maxlength=64>
</cr-input> </cr-input>
</div> </div>
......
...@@ -56,7 +56,7 @@ function getEmptyPrinter_() { ...@@ -56,7 +56,7 @@ function getEmptyPrinter_() {
}, },
printerPpdReferenceResolved: false, printerPpdReferenceResolved: false,
printerProtocol: 'ipp', printerProtocol: 'ipp',
printerQueue: '', printerQueue: 'ipp/print',
printerStatus: '', printerStatus: '',
}; };
} }
...@@ -258,10 +258,6 @@ Polymer({ ...@@ -258,10 +258,6 @@ Polymer({
/** @private */ /** @private */
addPressed_: function() { addPressed_: function() {
this.addPrinterInProgress_ = true; this.addPrinterInProgress_ = true;
// Set the default printer queue to be "ipp/print".
if (!this.newPrinter.printerQueue) {
this.set('newPrinter.printerQueue', 'ipp/print');
}
if (this.newPrinter.printerProtocol == 'ipp' || if (this.newPrinter.printerProtocol == 'ipp' ||
this.newPrinter.printerProtocol == 'ipps') { this.newPrinter.printerProtocol == 'ipps') {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment