Commit fafb4f34 authored by Nicolás Peña Moreno's avatar Nicolás Peña Moreno Committed by Chromium LUCI CQ

[EventTiming] Exclude target from toJSON

This CL removes the target from the return value of toJSON from a
PerformanceEventTiming entry, and modifies the WPT accordignly.
Context: https://github.com/WICG/event-timing/issues/97

Change-Id: I2a2f27f845f297157ca9f5ae561a9730dc242d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636058
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: default avatarYoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844762}
parent 838a8ee4
...@@ -85,7 +85,6 @@ void PerformanceEventTiming::BuildJSONValue(V8ObjectBuilder& builder) const { ...@@ -85,7 +85,6 @@ void PerformanceEventTiming::BuildJSONValue(V8ObjectBuilder& builder) const {
builder.AddNumber("processingStart", processingStart()); builder.AddNumber("processingStart", processingStart());
builder.AddNumber("processingEnd", processingEnd()); builder.AddNumber("processingEnd", processingEnd());
builder.AddBoolean("cancelable", cancelable_); builder.AddBoolean("cancelable", cancelable_);
builder.Add("target", target());
} }
void PerformanceEventTiming::Trace(Visitor* visitor) const { void PerformanceEventTiming::Trace(Visitor* visitor) const {
......
...@@ -27,12 +27,12 @@ ...@@ -27,12 +27,12 @@
'processingStart', 'processingStart',
'processingEnd', 'processingEnd',
'cancelable', 'cancelable',
'target',
]; ];
for (const key of keys) { for (const key of keys) {
assert_equals(json[key], entry[key], assert_equals(json[key], entry[key],
'PerformanceEventTiming ${key} entry does not match its toJSON value'); 'PerformanceEventTiming ${key} entry does not match its toJSON value');
} }
assert_equals(json['target'], undefined, 'toJSON should not include target');
}) })
); );
observer.observe({type: 'event'}); observer.observe({type: 'event'});
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment