Commit fb0705e0 authored by Travis Skare's avatar Travis Skare Committed by Commit Bot

[QRCode Desktop] Crash fix: don't hide icon on close or teardown.

Fixes crash when using a keyboard shortcut to close the active tab with
the bubble open.

Note with recent changes, the icon intentionally stays visible after
bubble close, so this call is no longer needed anyway.

Bug: 1107857
Change-Id: Ic254f28522e3b405591d068d2395aa4f4f281f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314696Reviewed-by: default avatarKristi Park <kristipark@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791016}
parent 2406f15c
......@@ -65,8 +65,6 @@ QRCodeGeneratorBubbleController::qrcode_generator_bubble_view() const {
void QRCodeGeneratorBubbleController::OnBubbleClosed() {
qrcode_generator_bubble_ = nullptr;
Browser* browser = chrome::FindBrowserWithWebContents(web_contents_);
browser->window()->UpdatePageActionIcon(PageActionIconType::kQRCodeGenerator);
}
QRCodeGeneratorBubbleController::QRCodeGeneratorBubbleController() = default;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment