Commit fb0fbee3 authored by Julie Jeongeun Kim's avatar Julie Jeongeun Kim Committed by Commit Bot

Remove crash key logging in WebRequestPermissions

This CL removes crash key logging added to debug DCHECK error
at WebRequestPermissions::HideRequest().

Bug: 1145496
Change-Id: I73728e5e85907b52bc63c7c267934300a4b2f8cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546386Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#828699}
parent d3dd69af
......@@ -267,27 +267,12 @@ bool WebRequestPermissions::HideRequest(
if (!request.is_navigation_request)
return true;
if (request.web_request_type !=
extensions::WebRequestResourceType::MAIN_FRAME &&
request.web_request_type !=
extensions::WebRequestResourceType::SUB_FRAME &&
request.web_request_type !=
extensions::WebRequestResourceType::OBJECT) {
// TODO(crbug.com/1145496): Remove crash key logging once the DCHECK
// failure below is fixed.
static auto* web_request_type_key = base::debug::AllocateCrashKeyString(
"web_request_type", base::debug::CrashKeySize::Size32);
static auto* url_key = base::debug::AllocateCrashKeyString(
"web_request_url", base::debug::CrashKeySize::Size256);
base::debug::ScopedCrashKeyString scoped_web_request_type(
web_request_type_key,
WebRequestResourceTypeToString(request.web_request_type));
base::debug::ScopedCrashKeyString scoped_url(
url_key, request.url.possibly_invalid_spec());
DCHECK(false);
}
DCHECK(request.web_request_type ==
extensions::WebRequestResourceType::MAIN_FRAME ||
request.web_request_type ==
extensions::WebRequestResourceType::SUB_FRAME ||
request.web_request_type ==
extensions::WebRequestResourceType::OBJECT);
// Hide sub-frame requests to clientsX.google.com.
// TODO(crbug.com/890006): Determine if the code here can be cleaned up
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment