Commit fb10747f authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Hide stack_tools behind arg

Hides //build/android:stack_tools behind build_with_chromium. Several
other projects such as V8 pull in //build, but don't pull in
//third_party/android_platform, which causes issues with stack_tools.

Bug: 1043646
Change-Id: I968f2435a3b941ed603ad608419a3855a0446b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067924
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743375}
parent 860e58a8
...@@ -124,12 +124,17 @@ python_library("bundle_wrapper_script_py") { ...@@ -124,12 +124,17 @@ python_library("bundle_wrapper_script_py") {
# Tools necessary for symbolizing tombstones or stack traces that are output to # Tools necessary for symbolizing tombstones or stack traces that are output to
# logcat. # logcat.
group("stack_tools") { # Hidden behind build_with_chromium because some third party repos that use
data = [ # //build don't pull in //third_party/android_platform.
"tombstones.py", if (build_with_chromium) {
"pylib/symbols/", group("stack_tools") {
"stacktrace/", data = [
] "tombstones.py",
"pylib/symbols/",
"stacktrace/",
]
data_deps = [ "//third_party/android_platform/development/scripts:stack_py" ] data_deps =
[ "//third_party/android_platform/development/scripts:stack_py" ]
}
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment