Commit fb1a0394 authored by manuk's avatar manuk Committed by Commit Bot

[omnibox chrome:omnibox]: Add full table header names to their tooltips.

Currently, only headers for boolean fields have their name included in
their tooltip. On small browser windows, the displayed header names can
become truncated. To avoid confusion when interpreting "Ass..." or
"Provider & ...", this CL adds the full header names to their tooltips,
followed by a new line.

Additionally, this CL expands the tooltip for the header "URL &
URLStripped" to describe both fields; previously, it only described URL.

Bug: 891303
Change-Id: I13fedc0679aeb68c7baeab4ebd7eed227a93d889
Reviewed-on: https://chromium-review.googlesource.com/c/1491797
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636178}
parent 36672ed0
...@@ -949,18 +949,18 @@ cr.define('omnibox_output', function() { ...@@ -949,18 +949,18 @@ cr.define('omnibox_output', function() {
const COLUMNS = [ const COLUMNS = [
new Column( new Column(
['Provider', 'Type'], '', 'providerAndType', true, ['Provider', 'Type'], '', 'providerAndType', true,
'The AutocompleteProvider suggesting this result. / The type of the ' + 'Provider & Type\nThe AutocompleteProvider suggesting this result. / ' +
'result.', 'The type of the result.',
['providerName', 'type'], OutputPairProperty), ['providerName', 'type'], OutputPairProperty),
new Column( new Column(
['Relevance'], '', 'relevance', true, ['Relevance'], '', 'relevance', true,
'The result score. Higher is more relevant.', ['relevance'], 'Relevance\nThe result score. Higher is more relevant.', ['relevance'],
OutputTextProperty), OutputTextProperty),
new Column( new Column(
['Contents', 'Description', 'Answer'], '', 'contentsAndDescription', ['Contents', 'Description', 'Answer'], '', 'contentsAndDescription',
true, true,
'The text that is presented identifying the result. / The page title ' + 'Contents & Description & Answer\nThe text that is presented ' +
'of the result.', 'identifying the result. / The page title of the result.',
['image', 'contents', 'description', 'answer'], OutputAnswerProperty), ['image', 'contents', 'description', 'answer'], OutputAnswerProperty),
new Column( new Column(
['D'], '', 'allowedToBeDefaultMatch', true, ['D'], '', 'allowedToBeDefaultMatch', true,
...@@ -980,14 +980,15 @@ cr.define('omnibox_output', function() { ...@@ -980,14 +980,15 @@ cr.define('omnibox_output', function() {
['hasTabMatch'], OutputBooleanProperty), ['hasTabMatch'], OutputBooleanProperty),
new Column( new Column(
['URL', 'Stripped URL'], '', 'destinationUrl', true, ['URL', 'Stripped URL'], '', 'destinationUrl', true,
'The URL for the result.', 'URL & Stripped URL\nThe URL for the result. / The stripped URL for ' +
'the result.',
['destinationUrl', 'isSearchType', 'strippedDestinationUrl'], ['destinationUrl', 'isSearchType', 'strippedDestinationUrl'],
OutputUrlProperty), OutputUrlProperty),
new Column( new Column(
['Fill', 'Inline'], '', 'fillAndInline', false, ['Fill', 'Inline'], '', 'fillAndInline', false,
'The text shown in the omnibox when the result is selected. / The ' + 'Fill & Inline\nThe text shown in the omnibox when the result is ' +
'text shown in the omnibox as a blue highlight selection ' + 'selected. / The text shown in the omnibox as a blue highlight ' +
'following the cursor, if this match is shown inline.', 'selection following the cursor, if this match is shown inline.',
['fillIntoEdit', 'inlineAutocompletion'], ['fillIntoEdit', 'inlineAutocompletion'],
OutputOverlappingPairProperty), OutputOverlappingPairProperty),
new Column( new Column(
...@@ -1003,8 +1004,8 @@ cr.define('omnibox_output', function() { ...@@ -1003,8 +1004,8 @@ cr.define('omnibox_output', function() {
['Tran'], ['Tran'],
'https://cs.chromium.org/chromium/src/ui/base/page_transition_types.h' + 'https://cs.chromium.org/chromium/src/ui/base/page_transition_types.h' +
'?q=page_transition_types.h&sq=package:chromium&dr=CSs&l=14', '?q=page_transition_types.h&sq=package:chromium&dr=CSs&l=14',
'transition', false, 'How the user got to the result.', ['transition'], 'transition', false, 'Transition\nHow the user got to the result.',
OutputTextProperty), ['transition'], OutputTextProperty),
new Column( new Column(
['D'], '', 'providerDone', false, ['D'], '', 'providerDone', false,
'Done\nA green checkmark indicates that the provider is done looking ' + 'Done\nA green checkmark indicates that the provider is done looking ' +
...@@ -1012,12 +1013,12 @@ cr.define('omnibox_output', function() { ...@@ -1012,12 +1013,12 @@ cr.define('omnibox_output', function() {
['providerDone'], OutputBooleanProperty), ['providerDone'], OutputBooleanProperty),
new Column( new Column(
['Associated Keyword'], '', 'associatedKeyword', false, ['Associated Keyword'], '', 'associatedKeyword', false,
'If non-empty, a "press tab to search" hint will be shown and will ' + 'Associated Keyword\nIf non-empty, a "press tab to search" hint will ' +
'engage this keyword.', 'be shown and will engage this keyword.',
['associatedKeyword'], OutputTextProperty), ['associatedKeyword'], OutputTextProperty),
new Column( new Column(
['Keyword'], '', 'keyword', false, ['Keyword'], '', 'keyword', false,
'The keyword of the search engine to be used.', ['keyword'], 'Keyword\nThe keyword of the search engine to be used.', ['keyword'],
OutputTextProperty), OutputTextProperty),
new Column( new Column(
['D'], '', 'duplicates', false, ['D'], '', 'duplicates', false,
...@@ -1026,8 +1027,8 @@ cr.define('omnibox_output', function() { ...@@ -1026,8 +1027,8 @@ cr.define('omnibox_output', function() {
['duplicates'], OutputTextProperty), ['duplicates'], OutputTextProperty),
new Column( new Column(
['Additional Info'], '', 'additionalInfo', false, ['Additional Info'], '', 'additionalInfo', false,
'Provider-specific information about the result.', ['additionalInfo'], 'Additional Info\nProvider-specific information about the result.',
OutputKeyValueTuplesProperty) ['additionalInfo'], OutputKeyValueTuplesProperty)
]; ];
/** @type {!Column} */ /** @type {!Column} */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment