Fix an uninitialized field in the fileSystem.retainEntry implementation.

This caused files to be sometimes retained as directories, making it
impossible to restore access to them.

BUG=301692

Review URL: https://codereview.chromium.org/25443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226453 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/extensions/api/file_system/file_system_api.cc

@@ -974,9 +974,7 @@ void FileSystemRetainEntryFunction::RetainFileEntry(
 }
 
 void FileSystemRetainEntryFunction::SetIsDirectoryOnFileThread() {
-  if (base::DirectoryExists(path_)) {
-    is_directory_ = true;
-  }
+  is_directory_ = base::DirectoryExists(path_);
 }
 
 bool FileSystemIsRestorableFunction::RunImpl() {

chrome/browser/extensions/api/file_system/file_system_apitest.cc

@@ -593,6 +593,7 @@ IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiRetainEntry) {
   ASSERT_EQ(1u, file_entries.size());
   EXPECT_EQ(test_file, file_entries[0].path);
   EXPECT_EQ(1, file_entries[0].sequence_number);
+  EXPECT_FALSE(file_entries[0].is_directory);
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiRetainDirectoryEntry) {