Remove use of setOverlayScrollbarsEnabled in layout tests

Adding runtimeFlags.overlayScrollbarsEnabled would help to
make more of these branches take the overlay path

Bug: 661783
Change-Id: I1d5523922fe3d6c8f671edd1c54789ef9aae399d
Reviewed-on: https://chromium-review.googlesource.com/792833Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#521289}

third_party/WebKit/LayoutTests/compositing/overflow/non-reparented-overlay-scrollbars-expected.html

@@ -23,7 +23,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(false);
 }
 </script>

third_party/WebKit/LayoutTests/compositing/overflow/non-reparented-overlay-scrollbars.html

@@ -23,7 +23,7 @@
 </style>
 <script>
 if (window.internals)
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
 </script>
 <div id='scroller'>
   <div id='fixed'></div>

third_party/WebKit/LayoutTests/compositing/overflow/reflected-overlay-scrollbars-should-appear-without-compositing-expected.html

@@ -35,7 +35,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 

third_party/WebKit/LayoutTests/compositing/overflow/reflected-overlay-scrollbars-should-appear-without-compositing.html

@@ -35,7 +35,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(false);
 }
 

third_party/WebKit/LayoutTests/compositing/overflow/reflected-overlay-scrollbars-should-respect-ancestor-clip-expected.html

@@ -36,7 +36,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(false);
 }
 

third_party/WebKit/LayoutTests/compositing/overflow/reflected-overlay-scrollbars-should-respect-ancestor-clip.html

@@ -41,7 +41,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 

third_party/WebKit/LayoutTests/compositing/overflow/reparented-overlay-scrollbars-should-respect-ancestor-clip-expected.html

@@ -32,7 +32,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(false);
 }
 </script>

third_party/WebKit/LayoutTests/compositing/overflow/reparented-overlay-scrollbars-should-respect-ancestor-clip.html

@@ -37,7 +37,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 </script>

third_party/WebKit/LayoutTests/compositing/overflow/reparented-scrollbars-non-sc-anc.html

@@ -42,7 +42,7 @@ if (window.testRunner)
   testRunner.dumpAsText();
 
 if (window.internals) {
-  window.internals.settings.setOverlayScrollbarsEnabled(true);
+  window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
   window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 

third_party/WebKit/LayoutTests/compositing/overflow/reparented-unclipped-overlay-scrollbars-with-offset-from-renderer-expected.html

@@ -23,7 +23,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(false);
 }
 </script>

third_party/WebKit/LayoutTests/compositing/overflow/reparented-unclipped-overlay-scrollbars-with-offset-from-renderer.html

@@ -29,7 +29,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 </script>

third_party/WebKit/LayoutTests/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor.html

@@ -50,7 +50,7 @@ contents.
 </div>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 

third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement.html

@@ -19,7 +19,7 @@ with varying thicknesses.
 -->
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 </script>

third_party/WebKit/LayoutTests/compositing/scrollbars/nested-overlay-scrollbars.html

@@ -40,7 +40,7 @@
 </style>
 <script>
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 

third_party/WebKit/LayoutTests/compositing/squashing/squashing-inside-perspective-with-reparented-scrolling-expected.html

@@ -32,5 +32,5 @@
 </div>
 <script>
 if (window.internals)
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
 </script>

third_party/WebKit/LayoutTests/compositing/squashing/squashing-inside-perspective-with-reparented-scrolling.html

@@ -38,7 +38,7 @@
 // Check that a case with a reparented overflow control and a containing perspective node
 // paints the same with and without layer squashing.
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
 }
 </script>

third_party/WebKit/LayoutTests/css3/viewport-percentage-lengths/viewport-percentage-lengths-scaled-overlay-scrollbars.html

@@ -9,7 +9,7 @@
 </style>
 <script>
 if (window.internals)
-    internals.settings.setOverlayScrollbarsEnabled(true);
+    internals.runtimeFlags.overlayScrollbarsEnabled = true;
 if (window.testRunner)
     testRunner.dumpAsText();
 if (window.eventSender)

third_party/WebKit/LayoutTests/fast/block/float/float-change-composited-scrolling.html

@@ -4,7 +4,7 @@
 if (window.internals) {
   internals.settings.setPreferCompositingToLCDTextEnabled(true);
   internals.settings.setMockScrollbarsEnabled(true);
-  internals.settings.setOverlayScrollbarsEnabled(true);
+  internals.runtimeFlags.overlayScrollbarsEnabled = true;
 }
 
 if (window.testRunner)

third_party/WebKit/LayoutTests/fast/dom/partial-layout-block.html

@@ -28,7 +28,7 @@ html, body {
         testRunner.dumpAsText();
 
     if (window.internals)
-        window.internals.settings.setOverlayScrollbarsEnabled(true);
+        window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
 
     test(function() {
         var measure = document.getElementById('measure');

third_party/WebKit/LayoutTests/fast/dom/partial-layout-non-overlay-scrollbars.html

@@ -28,7 +28,7 @@
         testRunner.dumpAsText();
 
     if (window.internals)
-        window.internals.settings.setOverlayScrollbarsEnabled(true); // Note: We force non-overlay scrollbars with CSS.
+        window.internals.runtimeFlags.overlayScrollbarsEnabled = true; // Note: We force non-overlay scrollbars with CSS.
 
     var test = async_test("Test that partial layout works with non-overlay scrollbars.");
     setTimeout(function() {

third_party/WebKit/LayoutTests/fast/dom/partial-layout-overlay-scrollbars.html

@@ -23,7 +23,7 @@
         testRunner.dumpAsText();
 
     if (window.internals)
-        window.internals.settings.setOverlayScrollbarsEnabled(true);
+        window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
 
     var test = async_test("Test that partial layout works with overlay scrollbars.");
     setTimeout(function() {

third_party/WebKit/LayoutTests/fast/dom/root-client-size-iframe.html

@@ -13,7 +13,7 @@
     shouldBeDefined(window.internals);
 
     var originalOverlayScrollbars = internals.runtimeFlags.overlayScrollbarsEnabled;
-    internals.settings.setOverlayScrollbarsEnabled(true);
+    internals.runtimeFlags.overlayScrollbarsEnabled = true;
 
     function runTests() {
         clientWidthBefore = frame.contentDocument.documentElement.clientWidth;
@@ -24,7 +24,7 @@
         shouldBe("clientWidthBefore", "100");
         shouldBe("clientWidthAfter", "200");
 
-        internals.settings.setOverlayScrollbarsEnabled(originalOverlayScrollbars);
+        internals.runtimeFlags.overlayScrollbarsEnabled = originalOverlayScrollbars;
         finishJSTest();
     }
 </script>

third_party/WebKit/LayoutTests/fast/dom/root-client-size.html

@@ -39,15 +39,15 @@
 
     var originalOverlayScrollbars = internals.runtimeFlags.overlayScrollbarsEnabled;
 
-    internals.settings.setOverlayScrollbarsEnabled(true);
+    internals.runtimeFlags.overlayScrollbarsEnabled = true;
 
     runClientSizeTest("wide", false, false, 1);
     runClientSizeTest("tall", false, false, 1);
 
-    internals.settings.setOverlayScrollbarsEnabled(false);
+    internals.runtimeFlags.overlayScrollbarsEnabled = false;
 
     runClientSizeTest("wide", false, true, 0);
     runClientSizeTest("tall", true, false, 0);
 
-    internals.settings.setOverlayScrollbarsEnabled(originalOverlayScrollbars);
+    internals.runtimeFlags.overlayScrollbarsEnabled = originalOverlayScrollbars;
 </script>

third_party/WebKit/LayoutTests/fast/events/hit-test-cache-scrollbar-no-crash.html

@@ -18,7 +18,7 @@
 description("Ensure hit test cache works in correct scenarios of overlay scrollbars.");
 
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
 
     var parentDiv = document.getElementById("parent");
     var rect = parentDiv.getBoundingClientRect();
@@ -30,4 +30,4 @@ if (window.internals) {
     window.internals.elementFromPoint(document, rect.left + rect.width - 2, rect.top + (rect.height/2), false, false);
     shouldBe("window.internals.hitTestCacheHits(document)", "expectedCount");
 }
-</script>
\ No newline at end of file
+</script>

third_party/WebKit/LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html

@@ -19,7 +19,7 @@ html, body {
 <script>
 if (window.internals) {
     testRunner.dumpAsTextWithPixelResults();
-    internals.settings.setOverlayScrollbarsEnabled(true);
+    internals.runtimeFlags.overlayScrollbarsEnabled = true;
     internals.settings.setMockScrollbarsEnabled(true);
 }
 </script>
@@ -47,4 +47,4 @@ should have a scrollbar on the left.</p>
 </select>
 </div>
 </body>
-</html>
\ No newline at end of file
+</html>

third_party/WebKit/LayoutTests/fast/scrolling/overlay-scrollbars.html

@@ -20,7 +20,7 @@ html, body {
 <script>
 if (window.internals) {
     testRunner.dumpAsTextWithPixelResults();
-    internals.settings.setOverlayScrollbarsEnabled(true);
+    internals.runtimeFlags.overlayScrollbarsEnabled = true;
     internals.settings.setMockScrollbarsEnabled(true);
 }
 </script>

third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-hittest.html

@@ -6,7 +6,7 @@
 <script>
 description('Checks that clicking on scrollbar works when tickmarks are added.');
 if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
 }
 
 onload = function()

third_party/WebKit/LayoutTests/html/sections/body-quirk-client-size.html

@@ -39,15 +39,15 @@
 
     var originalOverlayScrollbars = internals.runtimeFlags.overlayScrollbarsEnabled;
 
-    internals.settings.setOverlayScrollbarsEnabled(true);
+    internals.runtimeFlags.overlayScrollbarsEnabled = true;
 
     runClientSizeTest("wide", false, false, 1);
     runClientSizeTest("tall", false, false, 1);
 
-    internals.settings.setOverlayScrollbarsEnabled(false);
+    internals.runtimeFlags.overlayScrollbarsEnabled = false;
 
     runClientSizeTest("wide", false, true, 0);
     runClientSizeTest("tall", true, false, 0);
 
-    internals.settings.setOverlayScrollbarsEnabled(originalOverlayScrollbars);
+    internals.runtimeFlags.overlayScrollbarsEnabled = originalOverlayScrollbars;
 </script>

third_party/WebKit/LayoutTests/paint/invalidation/scroll/destroy-overlay-scrollbar.html

@@ -2,7 +2,7 @@
 <script src="../resources/text-based-repaint.js"></script>
 <script>
 if (window.internals) {
-  internals.settings.setOverlayScrollbarsEnabled(true);
+  internals.runtimeFlags.overlayScrollbarsEnabled = true;
   internals.settings.setMockScrollbarsEnabled(true);
 }
 function repaintTest() {

third_party/WebKit/LayoutTests/plugins/overlay-scrollbar-mouse-capture.html

@@ -57,7 +57,7 @@
         // RuntimeEnabledFeature after the ScrollbarTheme is initialized. It
         // makes the non overlay scrollbars think they're overlay so it works
         // for this test but it should probably be in a unit test.
-        internals.settings.setOverlayScrollbarsEnabled(true);
+        internals.runtimeFlags.overlayScrollbarsEnabled = true;
 
         var d = document.getElementById('container');
         var plugin = document.createElement('object');

third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fades-out.html

 <!DOCTYPE html>
 <script>
   if (window.internals) {
-    window.internals.settings.setOverlayScrollbarsEnabled(true);
+    window.internals.runtimeFlags.overlayScrollbarsEnabled = true;
     window.internals.settings.setMockScrollbarsEnabled(true);
 
     window.onload = function() {

third_party/WebKit/LayoutTests/scrollbars/hidden-scrollbars-invisible.html

 <!DOCTYPE html>
 <script>
 if (window.internals) {
-  internals.settings.setOverlayScrollbarsEnabled(true);
+  internals.runtimeFlags.overlayScrollbarsEnabled = true;
   internals.settings.setMockScrollbarsEnabled(true);
 }
 </script>
@@ -15,7 +15,7 @@ if (window.internals) {
 <script>
   window.onload = function() {
     if (window.internals) {
-      internals.settings.setOverlayScrollbarsEnabled(true);
+      internals.runtimeFlags.overlayScrollbarsEnabled = true;
 
       var div = document.querySelector('#div');
       var iframe = document.querySelector('#iframe');

third_party/WebKit/LayoutTests/scrollbars/overlay-scrollbars-within-overflow-scroll.html

@@ -31,7 +31,7 @@ html, body { margin: 0; padding: 0; }
 
 <script>
 if (window.internals) {
-    internals.settings.setOverlayScrollbarsEnabled(true);
+    internals.runtimeFlags.overlayScrollbarsEnabled = true;
     internals.settings.setMockScrollbarsEnabled(true);
 }
 const outer = document.getElementById('outer');

third_party/WebKit/Source/core/testing/InternalSettings.cpp

@@ -168,10 +168,6 @@ void InternalSettings::setExperimentalContentSecurityPolicyFeaturesEnabled(
       enabled);
 }
 
-void InternalSettings::setOverlayScrollbarsEnabled(bool enabled) {
-  RuntimeEnabledFeatures::SetOverlayScrollbarsEnabled(enabled);
-}
-
 void InternalSettings::setViewportEnabled(bool enabled,
                                           ExceptionState& exception_state) {
   InternalSettingsGuardForSettings();

third_party/WebKit/Source/core/testing/InternalSettings.h

@@ -131,7 +131,6 @@ class InternalSettings final : public InternalSettingsGenerated,
   // cannot be changed after process start. These setters should
   // be removed or moved onto internals.runtimeFlags:
   void setLangAttributeAwareFormControlUIEnabled(bool);
-  void setOverlayScrollbarsEnabled(bool);
   void setExperimentalContentSecurityPolicyFeaturesEnabled(bool);
   void setImageAnimationPolicy(const String&, ExceptionState&);
   void setScrollTopLeftInteropEnabled(bool);

third_party/WebKit/Source/core/testing/InternalSettings.idl

@@ -60,7 +60,6 @@ interface InternalSettings : InternalSettingsGenerated {
     // cannot be changed after process start.  These setters should
     // be removed or moved onto internals.runtimeFlags:
     void setLangAttributeAwareFormControlUIEnabled(boolean enabled);
-    void setOverlayScrollbarsEnabled(boolean enabled);
     void setExperimentalContentSecurityPolicyFeaturesEnabled(boolean enabled);
     void setScrollTopLeftInteropEnabled(boolean enabled);
 };