Commit fb31b4cd authored by Xiaohan Wang's avatar Xiaohan Wang Committed by Commit Bot

Update GetAddressOf() PRESUBMIT

Make the message more clear about the ban of variants like
ReleaseAndGetAddressOf().

Bug: 914910
Change-Id: I16fb4cb51a619aea4f414601cf10279ac482992a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271072
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786095}
parent a889726f
......@@ -945,8 +945,9 @@ _BANNED_CPP_FUNCTIONS = (
'GetAddressOf',
(
'Improper use of Microsoft::WRL::ComPtr<T>::GetAddressOf() has been ',
'implicated in a few leaks. Use operator& instead. See ',
'http://crbug.com/914910 for more conversion guidance.'
'implicated in a few leaks. ReleaseAndGetAddressOf() is safe but ',
'operator& is generally recommended. So always use operator& instead. '
'See http://crbug.com/914910 for more conversion guidance.'
),
True,
(),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment