Commit fb3b2482 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

DOM Storage: Do not use mmap() when migrating data from SQLite.

Bug: 1000959
Change-Id: Ieed509995513719fb46a0161fa3819bd3ea295e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359233
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: default avatarKen Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#798747}
parent cc5f8dbb
......@@ -162,8 +162,10 @@ bool LegacyDomStorageDatabase::LazyOpen(bool create_if_needed) {
// service, so exclusive locking is appropriate.
db_->set_exclusive_locking();
// This db does not use [meta] table, store mmap status data elsewhere.
db_->set_mmap_alt_status();
// This database is only opened to migrate DOMStorage data to a new backend.
// Given the use case, mmap()'s performance improvements are not worth the
// (tiny amount of) problems that mmap() may cause.
db_->set_mmap_disabled();
if (file_path_.empty()) {
// This code path should only be triggered by unit tests.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment