Commit fb5a6945 authored by kylechar's avatar kylechar Committed by Commit Bot

Disable D3DVsync with OOP-D.

The D3DVsync feature doesn't work with OOP-D, so don't try to use it at
the same time. GpuVSyncProviderWin can be simplified with OOP-D as it's
just an ExternalBeginFrameSource essentially without the process
boundary.

Bug: 787814
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I814671841df65fcd3141bcfa2ca9db8ea745ea0b
Reviewed-on: https://chromium-review.googlesource.com/1057846Reviewed-by: default avatarJonathan Backer <backer@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558390}
parent c67717fe
......@@ -48,6 +48,7 @@ component("service") {
}
public_deps = [
"//base",
"//components/viz/common",
"//ipc",
"//ui/base",
"//ui/display",
......
include_rules = [
"+components/viz/common/features.h",
"+third_party/skia",
"+ui/accelerated_widget_mac",
"+ui/base",
......
......@@ -7,6 +7,7 @@
#include <memory>
#include "base/win/windows_version.h"
#include "components/viz/common/features.h"
#include "gpu/command_buffer/service/gpu_preferences.h"
#include "gpu/ipc/service/direct_composition_surface_win.h"
#include "gpu/ipc/service/gpu_vsync_provider_win.h"
......@@ -24,6 +25,12 @@ namespace gpu {
namespace {
bool IsGpuVSyncSignalSupported() {
// TODO(crbug.com/787814): D3DVsync needs to be rewritten to work with
// OOP-D. It's no longer requires any IPC, just an ExternalBeginFrameSource,
// so it should be much simpler.
if (base::FeatureList::IsEnabled(features::kVizDisplayCompositor))
return false;
// TODO(stanisc): http://crbug.com/467617 Limit to Windows 8.1+ for now
// because of locking issue caused by waiting for VSync on Win7 and Win 8.0.
return base::win::GetVersion() >= base::win::VERSION_WIN8_1 &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment