Commit fb5cb2be authored by Morten Stenshorne's avatar Morten Stenshorne Committed by Commit Bot

[LayoutNG] Column balancing fix for non-visible overflow containers.

Don't let contents of boxes with non-visible overflow affect initial
column balancing block-size estimate.

Bug: 829028
Change-Id: I7d4be18001da7f41676f1254df43ab0e083e3ee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425043
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809778}
parent 7ff62f12
...@@ -38,7 +38,10 @@ LayoutUnit CalculateColumnContentBlockSize( ...@@ -38,7 +38,10 @@ LayoutUnit CalculateColumnContentBlockSize(
offset = child.Offset().left; offset = child.Offset().left;
size = child->Size().width; size = child->Size().width;
} }
if (child->IsContainer()) { // TODO(mstensho): Need to detect whether we're actually clipping in the
// block direction. The combination of overflow-x:clip and
// overflow-y:visible should enter children here.
if (child->IsContainer() && !child->HasNonVisibleOverflow()) {
LayoutUnit children_size = CalculateColumnContentBlockSize( LayoutUnit children_size = CalculateColumnContentBlockSize(
To<NGPhysicalContainerFragment>(*child), To<NGPhysicalContainerFragment>(*child),
multicol_is_horizontal_writing_mode); multicol_is_horizontal_writing_mode);
......
...@@ -1176,7 +1176,6 @@ crbug.com/829028 virtual/layout_ng_block_frag/fragmentation/float-after-forced-b ...@@ -1176,7 +1176,6 @@ crbug.com/829028 virtual/layout_ng_block_frag/fragmentation/float-after-forced-b
crbug.com/829028 virtual/layout_ng_block_frag/fragmentation/overflow-crossing-boundary.html [ Failure ] crbug.com/829028 virtual/layout_ng_block_frag/fragmentation/overflow-crossing-boundary.html [ Failure ]
crbug.com/1079031 virtual/layout_ng_block_frag/fragmentation/relayout-abspos.html [ Failure ] crbug.com/1079031 virtual/layout_ng_block_frag/fragmentation/relayout-abspos.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fragmentation/remove-unbreakable-block-in-line-float.html [ Failure ] crbug.com/829028 virtual/layout_ng_block_frag/fragmentation/remove-unbreakable-block-in-line-float.html [ Failure ]
crbug.com/829028 virtual/layout_ng_block_frag/fragmentation/scrolling-contents-scroll.html [ Failure ]
### With LayoutNGFragmentTraversal (and LayoutNGFragmentItem) enabled: ### With LayoutNGFragmentTraversal (and LayoutNGFragmentItem) enabled:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment