feedback: Don't use deprecated resizeTo method.
The resizeTo function is deprecated, and it set the height of the overall window -- including window chrome. On mac, there are 20px or so of chrome at the top of the window. This resulted in the window being too short. See https://developer.chrome.com/apps/app_window#type-AppWindow TEST=on my personal mac, edit html of feedback page to contain an extra\ line, then edit feedback JS to match this CL and run \ resizeAppWindow(). Verify window size is correct. Fixed: 2461725 Change-Id: I0d75d9e07d25e2a93a9c3fa17c7dbb98913724dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508974 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#822917}
Showing
Please register or sign in to comment