Commit fb6de914 authored by rbpotter's avatar rbpotter Committed by Commit Bot

Extensions Web UI: Fix test to pass on Mac with HTML imports disabled

Fix CrExtensionsManagerTestWithMultipleExtensionTypesInstalled.* to
pass on Mac 10.13 with --disable-blink-features=HTMLImports

Reproduced test failure locally on Mac 10.13, and verified test passes
with fix.

Bug: 925517
Change-Id: I8cabf2fccc3c4a1660373d65d203854e1234664c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604204Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658728}
parent 6b884edc
...@@ -524,6 +524,7 @@ CrExtensionsManagerTestWithMultipleExtensionTypesInstalled = ...@@ -524,6 +524,7 @@ CrExtensionsManagerTestWithMultipleExtensionTypesInstalled =
/** @override */ /** @override */
get extraLibraries() { get extraLibraries() {
return super.extraLibraries.concat([ return super.extraLibraries.concat([
'../settings/test_util.js',
'manager_test.js', 'manager_test.js',
]); ]);
} }
...@@ -570,6 +571,7 @@ CrExtensionsManagerTestWithIdQueryParam = ...@@ -570,6 +571,7 @@ CrExtensionsManagerTestWithIdQueryParam =
/** @override */ /** @override */
get extraLibraries() { get extraLibraries() {
return super.extraLibraries.concat([ return super.extraLibraries.concat([
'../settings/test_util.js',
'manager_test.js', 'manager_test.js',
]); ]);
} }
......
...@@ -35,6 +35,12 @@ cr.define('extension_manager_tests', function() { ...@@ -35,6 +35,12 @@ cr.define('extension_manager_tests', function() {
setup(function() { setup(function() {
manager = document.querySelector('extensions-manager'); manager = document.querySelector('extensions-manager');
// Wait for the first view to be active before starting tests, if one is
// not active already. Sometimes, on Mac with native HTML imports
// disabled, no views are active at this point.
return manager.$.viewManager.querySelector('.active') ?
Promise.resolve() :
test_util.eventToPromise('view-enter-start', manager);
}); });
test(assert(TestNames.ItemListVisibility), function() { test(assert(TestNames.ItemListVisibility), function() {
......
...@@ -3,10 +3,6 @@ ...@@ -3,10 +3,6 @@
# HTML imports feature turned off, before the Blink team disables the feature by # HTML imports feature turned off, before the Blink team disables the feature by
# default. # default.
# TODO(rbpotter): Restore this test to the list of tests below, after failures
# on Mac 10.13 have been fixed.
-CrExtensionsManagerTestWithMultipleExtensionTypesInstalled.*
CrExtensionsSidebarTest.* CrExtensionsSidebarTest.*
CrExtensionsToolbarTest.* CrExtensionsToolbarTest.*
CrExtensionsItemsTest.* CrExtensionsItemsTest.*
...@@ -20,6 +16,7 @@ CrExtensionsItemListTest.* ...@@ -20,6 +16,7 @@ CrExtensionsItemListTest.*
CrExtensionsLoadErrorTest.* CrExtensionsLoadErrorTest.*
CrExtensionsManagerUnitTest.* CrExtensionsManagerUnitTest.*
CrExtensionsManagerUnitTestWithActivityLogFlag.* CrExtensionsManagerUnitTestWithActivityLogFlag.*
CrExtensionsManagerTestWithMultipleExtensionTypesInstalled.*
CrExtensionsManagerTestWithIdQueryParam.* CrExtensionsManagerTestWithIdQueryParam.*
CrExtensionsManagerTestWithActivityLogFlag.* CrExtensionsManagerTestWithActivityLogFlag.*
CrExtensionsShortcutTest.* CrExtensionsShortcutTest.*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment