camera: Migrate google-analytics-bundle.js to analytics.js

Bug: 980846
Test: Launch CCA and CCA can send metrics successfully
Tricium: disable
Change-Id: I2ed39b7fc1b133fd2ed8d6dc122f029101837b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106984
Commit-Queue: Wei Lee <wtlee@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Reviewed-by: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759149}

chrome/browser/resources/chromeos/camera/.eslintignore

-google-analytics-bundle.js
-comlink.js
+src/js/lib/*

chrome/browser/resources/chromeos/camera/BUILD.gn

@@ -140,8 +140,8 @@ copy("chrome_camera_app_js_device") {
 
 copy("chrome_camera_app_js_lib") {
   sources = [
+    "src/js/lib/analytics.js",
     "src/js/lib/comlink.js",
-    "src/js/lib/google-analytics-bundle.js",
   ]
 
   outputs = [ "$chrome_camera_app_dir/js/lib/{{source_file_part}}" ]

chrome/browser/resources/chromeos/camera/camera_resources.grd

@@ -14,7 +14,7 @@
     <structures>
       <structure name="IDR_CAMERA_ASYNC_WRITER_JS" file="src/js/models/async_writer.js" type="chrome_html" />
       <structure name="IDR_CAMERA_BACKGROUND_JS" file="src/js/background.js" type="chrome_html" />
-      <structure name="IDR_CAMERA_BUNDLE_JS" file="src/js/lib/google-analytics-bundle.js" type="chrome_html" />
+      <structure name="IDR_CAMERA_ANALYTICS_JS" file="src/js/lib/analytics.js" type="chrome_html" />
       <structure name="IDR_CAMERA_CAMERA3_DEVICE_INFO_JS" file="src/js/device/camera3_device_info.js" type="chrome_html" />
       <structure name="IDR_CAMERA_CAMERA_JS" file="src/js/views/camera.js" type="chrome_html" />
       <structure name="IDR_CAMERA_CAMERA_INTENT_JS" file="src/js/views/camera_intent.js" type="chrome_html" />

chrome/browser/resources/chromeos/camera/src/js/BUILD.gn

@@ -63,7 +63,7 @@ js_library("gallerybutton") {
 js_library("metrics") {
   deps = [
     ":state",
-    "externs:chrome_platform_analytics",
+    "externs:universal_analytics_api",
   ]
 }
 

chrome/browser/resources/chromeos/camera/src/js/browser_proxy/browser_proxy.js

@@ -124,6 +124,13 @@ class ChromeAppBrowserProxy {
   sendMessage(extensionId, message) {
     chrome.runtime.sendMessage(extensionId, message);
   }
+
+  /** @override */
+  addDummyHistoryIfNotAvailable() {
+    // Since GA will use history.length to generate hash but it is not available
+    // in platform apps, set it to 1 manually.
+    window.history.length = 1;
+  }
 }
 
 export const browserProxy = new ChromeAppBrowserProxy();

chrome/browser/resources/chromeos/camera/src/js/browser_proxy/browser_proxy_interface.js

@@ -117,4 +117,9 @@ export class BrowserProxy {
    * @abstract
    */
   sendMessage(extensionId, message) {}
+
+  /**
+   * @abstract
+   */
+  addDummyHistoryIfNotAvailable() {}
 }

chrome/browser/resources/chromeos/camera/src/js/browser_proxy/webui_browser_proxy.js

@@ -136,6 +136,11 @@ class WebUIBrowserProxy {
   sendMessage(extensionId, message) {
     NOTIMPLEMENTED();
   }
+
+  /** @override */
+  addDummyHistoryIfNotAvailable() {
+    // no-ops
+  }
 }
 
 export const browserProxy = new WebUIBrowserProxy();

chrome/browser/resources/chromeos/camera/src/js/externs/BUILD.gn

@@ -4,10 +4,10 @@
 
 import("//third_party/closure_compiler/compile_js.gni")
 
-js_library("chrome_platform_analytics") {
+js_library("universal_analytics_api") {
   sources = []
 
-  externs_list = [ "chrome_platform_analytics.js" ]
+  externs_list = [ "universal_analytics_api.js" ]
 }
 
 js_library("w3c_fileapi") {

chrome/browser/resources/chromeos/camera/src/js/externs/chrome_platform_analytics.js

-// Copyright 2019 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * @fileoverview Externs for chrome-platform-analytics library.
- * @see https://github.com/googlearchive/chrome-platform-analytics/wiki
- * @externs
- */
-
-/* eslint-disable valid-jsdoc */
-
-const analytics = {};
-
-/**
- * @constructor
- * @struct
- */
-analytics.EventBuilder = function() {};
-
-/**
- * @param {!analytics.EventBuilder.Dimension} dimension
- * @return {!analytics.EventBuilder}
- */
-analytics.EventBuilder.prototype.dimension = function(dimension) {};
-
-/**
- * @param {string} category
- * @return {!analytics.EventBuilder}
- */
-analytics.EventBuilder.prototype.category = function(category) {};
-
-/**
- * @param {string} action
- * @return {!analytics.EventBuilder}
- */
-analytics.EventBuilder.prototype.action = function(action) {};
-
-/**
- * @param {string} label
- * @return {!analytics.EventBuilder}
- */
-analytics.EventBuilder.prototype.label = function(label) {};
-
-/**
- * @param {number} value
- * @return {!analytics.EventBuilder}
- */
-analytics.EventBuilder.prototype.value = function(value) {};
-
-/**
- * @typedef {{
- *   index: number,
- *   value: string
- * }}
- */
-analytics.EventBuilder.Dimension;
-
-/**
- * @interface
- */
-analytics.Tracker = function() {};
-
-/**
- * @param {!analytics.EventBuilder} eventBuilder
- */
-analytics.Tracker.prototype.send;

chrome/browser/resources/chromeos/camera/src/js/lib/.clang-format

+DisableFormat: true

chrome/browser/resources/chromeos/camera/src/js/lib/README.md

-# google-analytics-bundle.js
+# analytics.js
 
-* [Project Page](https://github.com/googlearchive/chrome-platform-analytics)
+* [Project Page](https://developers.google.com/analytics/devguides/collection/analyticsjs)
+* The extern file [universal_analytics_api.js]((https://github.com/google/closure-compiler/blob/master/contrib/externs/universal_analytics_api.js)) is copied from the [closure compiler project](https://github.com/google/closure-compiler)
 
 # comlink.js
 

chrome/browser/resources/chromeos/camera/src/views/background.html

@@ -4,7 +4,6 @@
      found in the LICENSE file. -->
 <html>
   <head>
-    <script src="../js/lib/google-analytics-bundle.js"></script>
     <script src="../js/mojo/mojo_bindings_lite.js"></script>
     <script src="../js/mojo/camera_intent.mojom-lite.js"></script>
     <script src="../js/mojo/camera_app_helper.mojom-lite.js"></script>

chrome/browser/resources/chromeos/camera/src/views/main.html

@@ -9,7 +9,6 @@
     <title>&#xfeff;</title>
     <meta charset="utf-8">
     <link rel="stylesheet" href="../css/main.css">
-    <script src="../js/lib/google-analytics-bundle.js"></script>
     <script src="../js/mojo/mojo_bindings_lite.js"></script>
     <script src="../js/mojo/time.mojom-lite.js"></script>
     <script src="../js/mojo/idle_manager.mojom-lite.js"></script>