Commit fb8feaa6 authored by Andreas Papacharalampous's avatar Andreas Papacharalampous Committed by Commit Bot

views: use kFixed instead of kUsePreferred

kUsePreferred likes to ignore text wrapping, making this view
really long because of the long text present. along with this,
the text was re-aligned to be even with the checkbox.

Bug: 1071831
Change-Id: I40de122e40149de878794ea0c0a7409a1f858078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359732Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798619}
parent f5a1afbc
......@@ -254,8 +254,8 @@ std::unique_ptr<views::View> SessionCrashedBubbleView::CreateUmaOptInView() {
gfx::Range after_link_range(offset + link_text.length(), uma_text.length());
if (!after_link_range.is_empty())
uma_label->AddStyleRange(after_link_range, uma_style);
// Shift the text down by 1px to align with the checkbox.
uma_label->SetBorder(views::CreateEmptyBorder(1, 0, 0, 0));
// Shift the text down by 3px to align with the checkbox.
uma_label->SetBorder(views::CreateEmptyBorder(3, 0, 0, 0));
// Checkbox for metric reporting setting.
auto uma_option = std::make_unique<views::Checkbox>(base::string16());
......@@ -276,7 +276,7 @@ std::unique_ptr<views::View> SessionCrashedBubbleView::CreateUmaOptInView() {
ChromeLayoutProvider::Get()->GetDistanceMetric(
views::DISTANCE_RELATED_LABEL_HORIZONTAL));
cs->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1.0,
views::GridLayout::ColumnSize::kUsePreferred, 0, 0);
views::GridLayout::ColumnSize::kFixed, 0, 0);
uma_layout->StartRow(views::GridLayout::kFixedSize, kReportColumnSetId);
uma_option_ = uma_layout->AddView(std::move(uma_option));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment