Add support to update network icon when dark/light mode is toggled

Bug: 1169404
Change-Id: I458dee6a73e071f9f4d99dabf3907e5afb45963d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642925Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846354}

ash/system/network/active_network_icon.h

@@ -62,6 +62,8 @@ class ASH_EXPORT ActiveNetworkIcon : public TrayNetworkStateObserver {
                           network_icon::IconType icon_type,
                           bool* animating);
 
+  void PurgeNetworkIconCache();
+
  private:
   gfx::ImageSkia GetSingleImage(network_icon::IconType icon_type,
                                 bool* animating);
@@ -86,7 +88,6 @@ class ASH_EXPORT ActiveNetworkIcon : public TrayNetworkStateObserver {
   void ActiveNetworkStateChanged() override;
   void NetworkListChanged() override;
 
-  void PurgeNetworkIconCache();
   const chromeos::network_config::mojom::NetworkStateProperties*
   GetNetworkForType(Type type);
 

ash/system/network/network_feature_pod_button.cc

@@ -136,6 +136,17 @@ void NetworkFeaturePodButton::ActiveNetworkStateChanged() {
   Update();
 }
 
+void NetworkFeaturePodButton::OnThemeChanged() {
+  FeaturePodButton::OnThemeChanged();
+
+  // Need to redraw all network icons with new colors.
+  Shell::Get()
+      ->system_tray_model()
+      ->active_network_icon()
+      ->PurgeNetworkIconCache();
+  NetworkIconChanged();
+}
+
 const char* NetworkFeaturePodButton::GetClassName() const {
   return "NetworkFeaturePodButton";
 }

ash/system/network/network_feature_pod_button.h

@@ -31,6 +31,7 @@ class NetworkFeaturePodButton : public FeaturePodButton,
   void ActiveNetworkStateChanged() override;
 
   // views::Button:
+  void OnThemeChanged() override;
   const char* GetClassName() const override;
 
  private:

ash/system/network/network_icon.cc

@@ -79,6 +79,7 @@ class NetworkIconImpl {
   Badge technology_badge_ = {};
   bool show_vpn_badge_ = false;
   bool is_roaming_ = false;
+  bool is_dark_themed_ = false;
 
   // Generated icon image.
   gfx::ImageSkia image_;
@@ -300,7 +301,8 @@ gfx::ImageSkia GetConnectingVpnImage(IconType icon_type) {
 NetworkIconImpl::NetworkIconImpl(const std::string& guid,
                                  IconType icon_type,
                                  NetworkType network_type)
-    : icon_type_(icon_type) {
+    : icon_type_(icon_type),
+      is_dark_themed_(AshColorProvider::Get()->IsDarkModeEnabled()) {
   // Default image is null.
 }
 
@@ -332,6 +334,11 @@ void NetworkIconImpl::Update(const NetworkStateProperties* network,
     dirty = true;
   }
 
+  if (is_dark_themed_ != AshColorProvider::Get()->IsDarkModeEnabled()) {
+    is_dark_themed_ = AshColorProvider::Get()->IsDarkModeEnabled();
+    dirty = true;
+  }
+
   if (dirty) {
     // Set the icon and badges based on the network and generate the image.
     GenerateImage(network);