Commit fbe1f232 authored by Theresa Wellington's avatar Theresa Wellington Committed by Commit Bot

Remove Nexus_5-19 from RenderTestRule models

The KitKat bot on the CQ is currently not running
chrome_public_test_apk, which makes generating new, reliable goldens
more challenging. Remove the N5 KitKat bot from the list of models for
now.

BUG=1060245

Change-Id: I3cd75ff0ca14baa8e68034d803c904733c91cc0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108912
Auto-Submit: Theresa  <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751506}
parent 5c44b2a9
...@@ -77,8 +77,10 @@ public class RenderTestRule extends TestWatcher { ...@@ -77,8 +77,10 @@ public class RenderTestRule extends TestWatcher {
/** /**
* This is a list of model-SDK version identifiers for devices we maintain golden images for. * This is a list of model-SDK version identifiers for devices we maintain golden images for.
* If render tests are being run on a device of a model-sdk on this list, goldens should exist. * If render tests are being run on a device of a model-sdk on this list, goldens should exist.
* TODO(https://crbug.com/1060245): Re-add Nexus_5-19 when chrome_public_test_apk is back on the
* KitKat bot on the CQ.
*/ */
private static final String[] RENDER_TEST_MODEL_SDK_PAIRS = {"Nexus_5-19", "Nexus_5X-23"}; private static final String[] RENDER_TEST_MODEL_SDK_PAIRS = {"Nexus_5X-23"};
private enum ComparisonResult { MATCH, MISMATCH, GOLDEN_NOT_FOUND } private enum ComparisonResult { MATCH, MISMATCH, GOLDEN_NOT_FOUND }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment