Commit fbe56c46 authored by Daniel Bratell's avatar Daniel Bratell Committed by Commit Bot

Rename a constant in editing unit tests to make it more unique.

kDescription is the name of two constants in editing unit_tests and
in jumbo builds those collides. This renames one of them
kTestDescription to make both constants have unique names.

R=fs@opera.com

Bug: 
Change-Id: I7fcb2fde1a6841ef92fe7d55a7b363da7c2c7fa0
Reviewed-on: https://chromium-review.googlesource.com/568146Reviewed-by: default avatarFredrik Söderquist <fs@opera.com>
Commit-Queue: bratell at Opera <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#485970}
parent dd0e9b92
...@@ -8,23 +8,23 @@ ...@@ -8,23 +8,23 @@
namespace blink { namespace blink {
const char* const kDescription = "Test description"; const char* const kTestDescription = "Test description";
class SpellingMarkerTest : public ::testing::Test {}; class SpellingMarkerTest : public ::testing::Test {};
TEST_F(SpellingMarkerTest, MarkerType) { TEST_F(SpellingMarkerTest, MarkerType) {
DocumentMarker* marker = new SpellingMarker(0, 1, kDescription); DocumentMarker* marker = new SpellingMarker(0, 1, kTestDescription);
EXPECT_EQ(DocumentMarker::kSpelling, marker->GetType()); EXPECT_EQ(DocumentMarker::kSpelling, marker->GetType());
} }
TEST_F(SpellingMarkerTest, IsSpellCheckMarker) { TEST_F(SpellingMarkerTest, IsSpellCheckMarker) {
DocumentMarker* marker = new SpellingMarker(0, 1, kDescription); DocumentMarker* marker = new SpellingMarker(0, 1, kTestDescription);
EXPECT_TRUE(IsSpellCheckMarker(*marker)); EXPECT_TRUE(IsSpellCheckMarker(*marker));
} }
TEST_F(SpellingMarkerTest, ConstructorAndGetters) { TEST_F(SpellingMarkerTest, ConstructorAndGetters) {
SpellingMarker* marker = new SpellingMarker(0, 1, kDescription); SpellingMarker* marker = new SpellingMarker(0, 1, kTestDescription);
EXPECT_EQ(kDescription, marker->Description()); EXPECT_EQ(kTestDescription, marker->Description());
} }
} // namespace blink } // namespace blink
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment