Commit fc021e91 authored by isherman's avatar isherman Committed by Commit bot

[Clean-up] Remove NetworkStats code, which has been dead code since July 2014.

BUG=470630
TEST=none
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/1031203002

Cr-Commit-Position: refs/heads/master@{#322261}
parent 2c2efdc8
......@@ -25,6 +25,7 @@
#include "chrome/browser/metrics/chrome_stability_metrics_provider.h"
#include "chrome/browser/metrics/drive_metrics_provider.h"
#include "chrome/browser/metrics/omnibox_metrics_provider.h"
#include "chrome/browser/metrics/time_ticks_experiment_win.h"
#include "chrome/browser/ui/browser_otr_state.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_switches.h"
......@@ -220,8 +221,10 @@ std::string ChromeMetricsServiceClient::GetVersionString() {
}
void ChromeMetricsServiceClient::OnLogUploadComplete() {
// Collect network stats after each UMA upload.
network_stats_uploader_.CollectAndReportNetworkStats();
// Collect time ticks stats after each UMA upload.
#if defined(OS_WIN)
chrome::CollectTimeTicksStats();
#endif
}
void ChromeMetricsServiceClient::StartGatheringMetrics(
......
......@@ -13,7 +13,6 @@
#include "base/memory/weak_ptr.h"
#include "base/threading/thread_checker.h"
#include "chrome/browser/metrics/metrics_memory_details.h"
#include "chrome/browser/metrics/network_stats_uploader.h"
#include "components/metrics/metrics_service_client.h"
#include "components/metrics/profiler/tracking_synchronizer_observer.h"
#include "content/public/browser/notification_observer.h"
......@@ -24,6 +23,7 @@ class DriveMetricsProvider;
class GoogleUpdateMetricsProviderWin;
class PluginMetricsProvider;
class PrefRegistrySimple;
class PrefService;
#if !defined(OS_CHROMEOS) && !defined(OS_IOS)
class SigninStatusMetricsProvider;
......@@ -140,8 +140,6 @@ class ChromeMetricsServiceClient
// that has been registered with MetricsService. On other platforms, is NULL.
ChromeOSMetricsProvider* chromeos_metrics_provider_;
NetworkStatsUploader network_stats_uploader_;
// Saved callback received from CollectFinalMetrics().
base::Closure collect_final_metrics_done_callback_;
......
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/metrics/network_stats_uploader.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/metrics/time_ticks_experiment_win.h"
#include "chrome/browser/net/network_stats.h"
#include "chrome/common/net/test_server_locations.h"
#if !defined(OS_POSIX)
#include "chrome/installer/util/browser_distribution.h"
#endif
NetworkStatsUploader::NetworkStatsUploader() {
#if defined(OS_POSIX)
network_stats_server_ = chrome_common_net::kEchoTestServerLocation;
#else
BrowserDistribution* dist = BrowserDistribution::GetDistribution();
network_stats_server_ = dist->GetNetworkStatsServer();
#endif
}
NetworkStatsUploader::~NetworkStatsUploader() {
}
void NetworkStatsUploader::CollectAndReportNetworkStats() {
IOThread* io_thread = g_browser_process->io_thread();
if (!io_thread)
return;
chrome_browser_net::CollectNetworkStats(network_stats_server_, io_thread);
#if defined(OS_WIN)
chrome::CollectTimeTicksStats();
#endif
}
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef CHROME_BROWSER_METRICS_NETWORK_STATS_UPLOADER_H_
#define CHROME_BROWSER_METRICS_NETWORK_STATS_UPLOADER_H_
#include <string>
#include "base/basictypes.h"
class PrefService;
class PrefRegistrySimple;
// NetworkStatsUploader implements the collection of various network stats,
// which is done upon successful transmission of an UMA log.
class NetworkStatsUploader {
public:
NetworkStatsUploader();
~NetworkStatsUploader();
// Collects and reports various network stats to external servers.
void CollectAndReportNetworkStats();
private:
// The TCP/UDP echo server to collect network connectivity stats.
std::string network_stats_server_;
DISALLOW_COPY_AND_ASSIGN(NetworkStatsUploader);
};
#endif // CHROME_BROWSER_METRICS_NETWORK_STATS_UPLOADER_H_
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
......@@ -1733,8 +1733,6 @@
'browser/metrics/metrics_reporting_state.h',
'browser/metrics/metrics_services_manager.cc',
'browser/metrics/metrics_services_manager.h',
'browser/metrics/network_stats_uploader.cc',
'browser/metrics/network_stats_uploader.h',
'browser/metrics/omnibox_metrics_provider.cc',
'browser/metrics/omnibox_metrics_provider.h',
'browser/metrics/perf_provider_chromeos.cc',
......@@ -1814,8 +1812,6 @@
'browser/net/net_log_temp_file.h',
'browser/net/net_pref_observer.cc',
'browser/net/net_pref_observer.h',
'browser/net/network_stats.cc',
'browser/net/network_stats.h',
'browser/net/preconnect.cc',
'browser/net/preconnect.h',
'browser/net/prediction_options.cc',
......
......@@ -156,7 +156,6 @@
'browser/net/evicted_domain_cookie_counter_unittest.cc',
'browser/net/net_error_tab_helper_unittest.cc',
'browser/net/net_log_temp_file_unittest.cc',
'browser/net/network_stats_unittest.cc',
'browser/net/predictor_unittest.cc',
'browser/net/pref_proxy_config_tracker_impl_unittest.cc',
'browser/net/probe_message_unittest.cc',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment