Commit fc249b8d authored by xan@webkit.org's avatar xan@webkit.org

2009-04-18 Xan Lopez <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Do not call ATK setters in the getters, just return the
        value. Among other things calling the setter will emit the notify
        signal, which is wrong.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42906 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent ee5d8a2b
2009-04-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Do not call ATK setters in the getters, just return the
value. Among other things calling the setter will emit the notify
signal, which is wrong.
* page/gtk/AccessibilityObjectWrapperAtk.cpp:
2009-04-16 Xan Lopez <xlopez@igalia.com> 2009-04-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha. Reviewed by Gustavo Noronha.
...@@ -121,21 +121,14 @@ extern "C" { ...@@ -121,21 +121,14 @@ extern "C" {
static const gchar* webkit_accessible_get_name(AtkObject* object) static const gchar* webkit_accessible_get_name(AtkObject* object)
{ {
// TODO: Deal with later changes. return returnString(core(object)->stringValue());
if (!object->name)
atk_object_set_name(object, core(object)->stringValue().utf8().data());
return object->name;
} }
static const gchar* webkit_accessible_get_description(AtkObject* object) static const gchar* webkit_accessible_get_description(AtkObject* object)
{ {
// TODO: the Mozilla MSAA implementation prepends "Description: " // TODO: the Mozilla MSAA implementation prepends "Description: "
// Should we do this too? // Should we do this too?
return returnString(core(object)->accessibilityDescription());
// TODO: Deal with later changes.
if (!object->description)
atk_object_set_description(object, core(object)->accessibilityDescription().utf8().data());
return object->description;
} }
static AtkObject* webkit_accessible_get_parent(AtkObject* object) static AtkObject* webkit_accessible_get_parent(AtkObject* object)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment