Commit fc2f4ea8 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Sheriff] Fix disabling SafetyTipPageInfoBubbleViewBrowserTest tests

Forgot the MAYBE_ prefix in test itself (yay, Mondays!)

TBR=jdeblasio@chromium.org
NOTRY=True

Bug: 1139955
Change-Id: Ic94974f53c57faede67731b41126dd91ec4b2999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485496Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818549}
parent 526613bf
...@@ -633,7 +633,7 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -633,7 +633,7 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
#define MAYBE_LeaveSiteStillWarnsAfter LeaveSiteStillWarnsAfter #define MAYBE_LeaveSiteStillWarnsAfter LeaveSiteStillWarnsAfter
#endif #endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
LeaveSiteStillWarnsAfter) { MAYBE_LeaveSiteStillWarnsAfter) {
auto kNavigatedUrl = GetURL("site1.com"); auto kNavigatedUrl = GetURL("site1.com");
if (!IsSuspiciousSiteWarningEnabled()) { if (!IsSuspiciousSiteWarningEnabled()) {
...@@ -861,7 +861,7 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -861,7 +861,7 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
#define MAYBE_SafetyTipShownHistogram SafetyTipShownHistogram #define MAYBE_SafetyTipShownHistogram SafetyTipShownHistogram
#endif #endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
SafetyTipShownHistogram) { MAYBE_SafetyTipShownHistogram) {
const char kHistogramName[] = "Security.SafetyTips.SafetyTipShown"; const char kHistogramName[] = "Security.SafetyTips.SafetyTipShown";
base::HistogramTester histograms; base::HistogramTester histograms;
...@@ -1032,7 +1032,7 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -1032,7 +1032,7 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
#define MAYBE_TimeOpenHistogram TimeOpenHistogram #define MAYBE_TimeOpenHistogram TimeOpenHistogram
#endif #endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
TimeOpenHistogram) { MAYBE_TimeOpenHistogram) {
if (!IsSuspiciousSiteWarningEnabled()) { if (!IsSuspiciousSiteWarningEnabled()) {
return; return;
} }
...@@ -1284,7 +1284,7 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -1284,7 +1284,7 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
WarningDismissalCausesUkmRecordingForBlocklist WarningDismissalCausesUkmRecordingForBlocklist
#endif #endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
WarningDismissalCausesUkmRecordingForBlocklist) { MAYBE_WarningDismissalCausesUkmRecordingForBlocklist) {
// Only test when any UI is actually enabled. // Only test when any UI is actually enabled.
if (!IsSuspiciousSiteWarningEnabled()) { if (!IsSuspiciousSiteWarningEnabled()) {
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment