Commit fc3376af authored by Alexei Svitkine's avatar Alexei Svitkine Committed by Commit Bot

Revert "Update system_profile.proto. Populate app_package_name"

This reverts commit c3884364.

Reason for revert: This has unintended consequences for Android Webview. Reverting so that the logic can be updated to not log the field for webview when the CL is relanded.

Original change's description:
> Update system_profile.proto. Populate app_package_name
> 
> Bug: 833214
> Change-Id: I5552bdca37a2e3e20a039b9a0ca316f4480b1217
> Reviewed-on: https://chromium-review.googlesource.com/1010055
> Commit-Queue: Shuo Weng <shuow@google.com>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551296}

TBR=asvitkine@chromium.org,wychen@chromium.org,shuow@google.com

Change-Id: I3c14d6f4b1a565d651c69be5d11a28959149f0c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 833214
Reviewed-on: https://chromium-review.googlesource.com/1014205Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551359}
parent 8c67b1c9
......@@ -173,10 +173,6 @@ void MetricsLog::RecordCoreSystemProfile(MetricsServiceClient* client,
#if defined(OS_ANDROID)
os->set_build_fingerprint(
base::android::BuildInfo::GetInstance()->android_build_fp());
std::string package_name =
base::android::BuildInfo::GetInstance()->package_name();
if (package_name != "com.android.chrome")
system_profile->set_app_package_name(package_name);
#endif
}
......
......@@ -156,8 +156,6 @@ TEST_F(MetricsLogTest, BasicRecord) {
#if defined(OS_ANDROID)
system_profile->mutable_os()->set_build_fingerprint(
base::android::BuildInfo::GetInstance()->android_build_fp());
system_profile->set_app_package_name(
base::android::BuildInfo::GetInstance()->package_name());
#endif
// Hard to mock.
......
Name: Metrics Protos
Short Name: metrics_proto
URL: This is the canonical public repository
Version: 192562418
Date: 2018/04/12 UTC
Version: 191322814
Date: 2018/04/02 UTC
License: BSD
Security Critical: Yes
......
......@@ -15,7 +15,7 @@ import "extension_install.proto";
// Stores information about the user's brower and system configuration.
// The system configuration fields are recorded once per client session.
// Next tag: 27
// Next tag: 26
message SystemProfileProto {
// The time when the client was compiled/linked, in seconds since the epoch.
optional int64 build_timestamp = 1;
......@@ -972,8 +972,4 @@ message SystemProfileProto {
// extensions from all fully-initialized profiles. If a single extension is
// installed in multiple profiles, it will be recorded multiple times.
repeated ExtensionInstallProto extension_install = 25;
// The Chrome package name on Android, if it's different from
// "com.android.chrome".
optional string app_package_name = 26;
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment