Commit fc5c65a7 authored by Simon Zünd's avatar Simon Zünd Committed by Commit Bot

[devtools] Debug.evaluateOnCallFrame must be non-interrupting

This CL prevents Debug.evaluateOnCallFrame to interrupt V8 execution.
This is necessary as V8 is not able to handle nested
Debug.evaluateOnCallFrame messages in a safe and correct manner.

Bug: chromium:1062448
Change-Id: I59f62c3c16a3052fe09043e06ced6b59c8364fdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139391
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: default avatarPeter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756998}
parent 921a109d
...@@ -35,7 +35,8 @@ const char kV8StateKey[] = "v8"; ...@@ -35,7 +35,8 @@ const char kV8StateKey[] = "v8";
const char kSessionId[] = "sessionId"; const char kSessionId[] = "sessionId";
bool ShouldInterruptForMethod(const String& method) { bool ShouldInterruptForMethod(const String& method) {
return method != "Runtime.evaluate" && method != "Runtime.callFunctionOn" && return method != "Debugger.evaluateOnCallFrame" &&
method != "Runtime.evaluate" && method != "Runtime.callFunctionOn" &&
method != "Runtime.runScript"; method != "Runtime.runScript";
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment