Commit fc7ff4b3 authored by Victor Hugo Vianna Silva's avatar Victor Hugo Vianna Silva Committed by Commit Bot

Re-enable sync E2E extensions tests on Mac and Windows

These tests were disabled a while ago by previous sync owners, let's try
re-enabling them.

Bug: 597319
Change-Id: Id66800f53f2af4ae0accb368f06dbf8c33642e6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462257Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#815519}
parent 28dff9b7
...@@ -39,13 +39,6 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, ...@@ -39,13 +39,6 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest,
ASSERT_TRUE(ExtensionsMatchChecker().Wait()); ASSERT_TRUE(ExtensionsMatchChecker().Wait());
} }
// E2E tests flaky on Mac and Windows: https://crbug.com/597319
#if defined(OS_MAC) || defined(OS_WIN)
#define MAYBE_E2E(test_name) test_name
#else
#define MAYBE_E2E(test_name) E2E_ENABLED(test_name)
#endif
// Flaky on Mac: http://crbug.com/535996 // Flaky on Mac: http://crbug.com/535996
#if defined(OS_MAC) #if defined(OS_MAC)
#define MAYBE_StartWithSameExtensions DISABLED_StartWithSameExtensions #define MAYBE_StartWithSameExtensions DISABLED_StartWithSameExtensions
...@@ -76,7 +69,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, ...@@ -76,7 +69,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest,
#define MAYBE_StartWithDifferentExtensions StartWithDifferentExtensions #define MAYBE_StartWithDifferentExtensions StartWithDifferentExtensions
#endif #endif
IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest,
MAYBE_E2E(MAYBE_StartWithDifferentExtensions)) { E2E_ENABLED(MAYBE_StartWithDifferentExtensions)) {
ResetSyncForPrimaryAccount(); ResetSyncForPrimaryAccount();
ASSERT_TRUE(SetupClients()); ASSERT_TRUE(SetupClients());
...@@ -137,7 +130,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, ...@@ -137,7 +130,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest,
static_cast<int>(GetInstalledExtensions(GetProfile(0)).size())); static_cast<int>(GetInstalledExtensions(GetProfile(0)).size()));
} }
IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, MAYBE_E2E(Add)) { IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, E2E_ENABLED(Add)) {
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AllProfilesHaveSameExtensions()); ASSERT_TRUE(AllProfilesHaveSameExtensions());
...@@ -147,7 +140,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, MAYBE_E2E(Add)) { ...@@ -147,7 +140,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, MAYBE_E2E(Add)) {
EXPECT_EQ(1u, GetInstalledExtensions(GetProfile(0)).size()); EXPECT_EQ(1u, GetInstalledExtensions(GetProfile(0)).size());
} }
IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, MAYBE_E2E(Uninstall)) { IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, E2E_ENABLED(Uninstall)) {
ResetSyncForPrimaryAccount(); ResetSyncForPrimaryAccount();
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AllProfilesHaveSameExtensions()); ASSERT_TRUE(AllProfilesHaveSameExtensions());
...@@ -161,7 +154,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, MAYBE_E2E(Uninstall)) { ...@@ -161,7 +154,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, MAYBE_E2E(Uninstall)) {
} }
IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest, IN_PROC_BROWSER_TEST_F(TwoClientExtensionsSyncTest,
MAYBE_E2E(UpdateEnableDisableExtension)) { E2E_ENABLED(UpdateEnableDisableExtension)) {
ResetSyncForPrimaryAccount(); ResetSyncForPrimaryAccount();
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AllProfilesHaveSameExtensions()); ASSERT_TRUE(AllProfilesHaveSameExtensions());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment