Commit fc81e3ea authored by danakj's avatar danakj Committed by Commit Bot

Remove dead RenderWidgetHostViewEventHandler::ShowContextMenu()

R=avi@chromium.org

Change-Id: Ia1beb8f5e22c53e38803f44302785d63abe82363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391728Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804264}
parent 5ba693eb
...@@ -538,11 +538,6 @@ WebPreferences RenderViewHostImpl::GetWebkitPreferencesForWidget() { ...@@ -538,11 +538,6 @@ WebPreferences RenderViewHostImpl::GetWebkitPreferencesForWidget() {
return delegate_->GetOrCreateWebPreferences(); return delegate_->GetOrCreateWebPreferences();
} }
void RenderViewHostImpl::ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) {
GetDelegate()->GetDelegateView()->ShowContextMenu(render_frame_host, params);
}
void RenderViewHostImpl::DispatchRenderViewCreated() { void RenderViewHostImpl::DispatchRenderViewCreated() {
if (has_notified_about_creation_) if (has_notified_about_creation_)
return; return;
......
...@@ -301,9 +301,6 @@ class CONTENT_EXPORT RenderViewHostImpl ...@@ -301,9 +301,6 @@ class CONTENT_EXPORT RenderViewHostImpl
bool IsNeverComposited() override; bool IsNeverComposited() override;
WebPreferences GetWebkitPreferencesForWidget() override; WebPreferences GetWebkitPreferencesForWidget() override;
void ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) override;
// IPC message handlers. // IPC message handlers.
void OnShowView(int route_id, void OnShowView(int route_id,
WindowOpenDisposition disposition, WindowOpenDisposition disposition,
......
...@@ -18,9 +18,7 @@ class Rect; ...@@ -18,9 +18,7 @@ class Rect;
} }
namespace content { namespace content {
struct ContextMenuParams;
struct NativeWebKeyboardEvent; struct NativeWebKeyboardEvent;
class RenderFrameHost;
struct WebPreferences; struct WebPreferences;
// //
...@@ -79,11 +77,6 @@ class CONTENT_EXPORT RenderWidgetHostOwnerDelegate { ...@@ -79,11 +77,6 @@ class CONTENT_EXPORT RenderWidgetHostOwnerDelegate {
// between all widgets for the page. // between all widgets for the page.
virtual WebPreferences GetWebkitPreferencesForWidget() = 0; virtual WebPreferences GetWebkitPreferencesForWidget() = 0;
// Shows a context menu that is built using the context information
// provided in |params|.
virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) = 0;
protected: protected:
virtual ~RenderWidgetHostOwnerDelegate() {} virtual ~RenderWidgetHostOwnerDelegate() {}
}; };
......
...@@ -2241,18 +2241,6 @@ void RenderWidgetHostViewAura::SetTooltipsEnabled(bool enable) { ...@@ -2241,18 +2241,6 @@ void RenderWidgetHostViewAura::SetTooltipsEnabled(bool enable) {
} }
} }
void RenderWidgetHostViewAura::ShowContextMenu(
const ContextMenuParams& params) {
// Use RenderViewHostDelegate to get to the WebContentsViewAura, which will
// actually show the disambiguation popup.
// NOTE: This only works for main frame widgets then, as child frame widgets
// don't have an owner delegate and won't get access to the RenderViewHost
// here.
RenderWidgetHostOwnerDelegate* owner_delegate = host()->owner_delegate();
if (owner_delegate)
owner_delegate->ShowContextMenu(GetFocusedFrame(), params);
}
void RenderWidgetHostViewAura::NotifyRendererOfCursorVisibilityState( void RenderWidgetHostViewAura::NotifyRendererOfCursorVisibilityState(
bool is_visible) { bool is_visible) {
if (host()->is_hidden() || if (host()->is_hidden() ||
......
...@@ -341,7 +341,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura ...@@ -341,7 +341,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
RenderFrameHostImpl* GetFocusedFrame() const; RenderFrameHostImpl* GetFocusedFrame() const;
bool NeedsMouseCapture() override; bool NeedsMouseCapture() override;
void SetTooltipsEnabled(bool enable) override; void SetTooltipsEnabled(bool enable) override;
void ShowContextMenu(const ContextMenuParams& params) override;
void Shutdown() override; void Shutdown() override;
bool ShouldVirtualKeyboardOverlayContent() const; bool ShouldVirtualKeyboardOverlayContent() const;
......
...@@ -80,7 +80,6 @@ class CONTENT_EXPORT RenderWidgetHostViewEventHandler ...@@ -80,7 +80,6 @@ class CONTENT_EXPORT RenderWidgetHostViewEventHandler
// Returns whether the widget needs to grab mouse capture to work properly. // Returns whether the widget needs to grab mouse capture to work properly.
virtual bool NeedsMouseCapture() = 0; virtual bool NeedsMouseCapture() = 0;
virtual void SetTooltipsEnabled(bool enable) = 0; virtual void SetTooltipsEnabled(bool enable) = 0;
virtual void ShowContextMenu(const ContextMenuParams& params) = 0;
// Sends shutdown request. // Sends shutdown request.
virtual void Shutdown() = 0; virtual void Shutdown() = 0;
......
...@@ -26,8 +26,6 @@ class StubRenderWidgetHostOwnerDelegate : public RenderWidgetHostOwnerDelegate { ...@@ -26,8 +26,6 @@ class StubRenderWidgetHostOwnerDelegate : public RenderWidgetHostOwnerDelegate {
bool IsMainFrameActive() override; bool IsMainFrameActive() override;
bool IsNeverComposited() override; bool IsNeverComposited() override;
WebPreferences GetWebkitPreferencesForWidget() override; WebPreferences GetWebkitPreferencesForWidget() override;
void ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) override {}
}; };
} // namespace content } // namespace content
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment