DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect

Allow Console to evaluate without throwOnSideEffect when the entire
expression meets the same strict conditions used by JSAutocomplete.

Bug: 810176
Change-Id: If5c80250cd75d81eec1e495d0414903213fac930
Reviewed-on: https://chromium-review.googlesource.com/1028934
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555142}

third_party/WebKit/LayoutTests/http/tests/devtools/unit/needs-side-effect-check-expected.txt

+Test side effect check requirement tester.
+Expression "var x"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "import x"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "new x()"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "for (;;) {}"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "while () {}"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "123"
+PASS: needsSideEffectCheck: false, expected: false
+Expression "1+2"
+PASS: needsSideEffectCheck: false, expected: false
+Expression "x++"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "foo+name"
+PASS: needsSideEffectCheck: false, expected: false
+Expression "foo()+name"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "foo();name"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "name"
+PASS: needsSideEffectCheck: false, expected: false
+Expression "name[0]"
+PASS: needsSideEffectCheck: false, expected: false
+Expression "name[1+2]"
+PASS: needsSideEffectCheck: false, expected: false
+Expression "name.foo.bar"
+PASS: needsSideEffectCheck: false, expected: false
+Expression "name.foo[0].bar"
+PASS: needsSideEffectCheck: false, expected: false
+Expression "name.foo().bar"
+PASS: needsSideEffectCheck: true, expected: true
+Expression "syntax_error,,"
+PASS: needsSideEffectCheck: true, expected: true
+

third_party/WebKit/LayoutTests/http/tests/devtools/unit/needs-side-effect-check.js

+(async function() {
+  await TestRunner.loadModule('formatter');
+  await TestRunner.loadModule('object_ui');
+  TestRunner.addResult('Test side effect check requirement tester.');
+
+  await check(`var x`, true);
+  await check(`import x`, true);
+  await check(`new x()`, true);
+  await check(`for (;;) {}`, true);
+  await check(`while () {}`, true);
+  await check(`123`, false);
+  await check(`1+2`, false);
+  await check(`x++`, true);
+  await check(`foo+name`, false);
+  await check(`foo()+name`, true);
+  await check(`foo();name`, true);
+  await check(`name`, false);
+  await check(`name[0]`, false);
+  await check(`name[1+2]`, false);
+  await check(`name.foo.bar`, false);
+  await check(`name.foo[0].bar`, false);
+  await check(`name.foo().bar`, true);
+  await check(`syntax_error,,`, true);
+
+  TestRunner.completeTest();
+
+  async function check(text, expected) {
+    const actual = (await Formatter.formatterWorkerPool().hasPossibleSideEffects(text));
+    const differ = actual !== expected;
+    TestRunner.addResult(`Expression "${text}"\n${differ ? 'FAIL: ' : 'PASS: '}needsSideEffectCheck: ${actual}, expected: ${expected}`);
+  }
+})();

third_party/blink/renderer/devtools/front_end/console/ConsolePrompt.js

@@ -81,11 +81,14 @@ Console.ConsolePrompt = class extends UI.Widget {
       return;
     }
 
+    // Checking for possible side effects uses the same logic as JavaScriptAutocomplete.
+    // This grows the set of previewable expressions without whitelisting.
+    const hasPossibleSideEffects = await Formatter.formatterWorkerPool().hasPossibleSideEffects(text);
     const options = {
       expression: SDK.RuntimeModel.wrapObjectLiteralExpressionIfNeeded(text),
       includeCommandLineAPI: true,
       generatePreview: true,
-      throwOnSideEffect: true,
+      throwOnSideEffect: hasPossibleSideEffects,
       timeout: 500
     };
     const result = await executionContext.evaluate(options, true /* userGesture */, false /* awaitPromise */);

third_party/blink/renderer/devtools/front_end/formatter/FormatterWorkerPool.js

@@ -49,7 +49,7 @@ Formatter.FormatterWorkerPool = class {
 
     this._workerTasks.set(worker, null);
     this._processNextTask();
-    task.callback(event.data ? event.data : null);
+    task.callback(event.data);
   }
 
   /**
@@ -239,6 +239,14 @@ Formatter.FormatterWorkerPool = class {
     return /** @type {!Promise<?{baseExpression: string, possibleSideEffects:boolean}>} */ (
         this._runTask('findLastExpression', {content}));
   }
+
+  /**
+   * @param {string} content
+   * @return {!Promise<boolean>}
+   */
+  hasPossibleSideEffects(content) {
+    return /** @type {!Promise<boolean>} */ (this._runTask('hasPossibleSideEffects', {content}));
+  }
 };
 
 Formatter.FormatterWorkerPool.MaxWorkers = 2;

third_party/blink/renderer/devtools/front_end/formatter_worker/FormatterWorker.js

@@ -87,6 +87,9 @@ self.onmessage = function(event) {
     case 'findLastExpression':
       postMessage(FormatterWorker.findLastExpression(params.content));
       break;
+    case 'hasPossibleSideEffects':
+      postMessage(FormatterWorker.hasPossibleSideEffects(params.content));
+      break;
     default:
       console.error('Unsupport method name: ' + method);
   }
@@ -371,9 +374,18 @@ FormatterWorker.findLastExpression = function(content) {
   let baseExpression = parsedContent.substring(baseNode.start, parsedContent.length - suffix.length);
   if (baseExpression.startsWith('{'))
     baseExpression = `(${baseExpression})`;
+  const possibleSideEffects = FormatterWorker._possibleSideEffects(/** @type {!ESTree.Node} */ (baseNode));
+  return {baseExpression, possibleSideEffects};
+};
+
+/**
+ * @param {!ESTree.Node} node
+ * @return {boolean}
+ */
+FormatterWorker._possibleSideEffects = function(node) {
   const sideEffectFreeTypes = new Set([
     'MemberExpression', 'Identifier', 'BinaryExpression', 'Literal', 'TemplateLiteral', 'TemplateElement',
-    'ObjectExpression', 'ArrayExpression', 'Property', 'ThisExpression'
+    'ObjectExpression', 'ArrayExpression', 'Property', 'ThisExpression', 'Program', 'ExpressionStatement'
   ]);
   let possibleSideEffects = false;
   const sideEffectwalker = new FormatterWorker.ESTreeWalker(node => {
@@ -382,8 +394,25 @@ FormatterWorker.findLastExpression = function(content) {
     if (possibleSideEffects)
       return FormatterWorker.ESTreeWalker.SkipSubtree;
   });
-  sideEffectwalker.walk(/** @type {!ESTree.Node} */ (baseNode));
-  return {baseExpression, possibleSideEffects};
+  sideEffectwalker.walk(node);
+  return possibleSideEffects;
+};
+
+/**
+ * @param {string} text
+ * @return {boolean}
+ */
+FormatterWorker.hasPossibleSideEffects = function(text) {
+  if (text.length > 10000)
+    return true;
+  let ast = null;
+  try {
+    ast = acorn.parse(text, {ecmaVersion: 9});
+  } catch (e) {
+  }
+  if (!ast)
+    return true;
+  return FormatterWorker._possibleSideEffects(ast);
 };
 
 /**