Make GPU gold tests output CL-wide links

Makes GPU gold pixel tests output links to the triage page for the
entire CL instead of each individual image when running on the trybots.
This makes it so that users only need to open one link regardless of
how many failures there are in order to triage everything.

Bug: 1008524

Change-Id: I94891663fe09bb59ba386e7bd24bc72a4ffe1468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825907
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700441}

content/test/gpu/gpu_tests/pixel_integration_test.py

@@ -398,15 +398,25 @@ class PixelIntegrationTest(
               build_id_args + extra_imgtest_args)
       subprocess.check_output(cmd, stderr=subprocess.STDOUT)
     except CalledProcessError as e:
-      try:
-        # The triage link for the image is output to the failure file, so report
-        # that if it's available so it shows up in Milo. If for whatever reason
-        # the file is not present or malformed, the triage link will still be
-        # present in the stdout of the goldctl command.
-        with open(failure_file, 'r') as ff:
-          self.artifacts.CreateLink('gold_triage_link', ff.read())
-      except Exception:
-        logging.error('Failed to read contents of goldctl failure file')
+      # The triage link for the image is output to the failure file, so report
+      # that if it's available so it shows up in Milo. If for whatever reason
+      # the file is not present or malformed, the triage link will still be
+      # present in the stdout of the goldctl command.
+      # If we're running on a trybot, instead generate a link to all results
+      # for the CL so that the user can visit a single page instead of
+      # clicking on multiple links on potentially multiple bots.
+      if parsed_options.review_patch_issue:
+        cl_images = ('https://%s-gold.skia.org/search?'
+                     'issue=%s&new_clstore=true' % (
+                       SKIA_GOLD_INSTANCE, parsed_options.review_patch_issue))
+        self.artifacts.CreateLink('triage_link_for_entire_cl', cl_images)
+      else:
+        try:
+          with open(failure_file, 'r') as ff:
+            self.artifacts.CreateLink('gold_triage_link', ff.read())
+        except Exception:
+          logging.error('Failed to read contents of goldctl failure file')
+
       logging.error('goldctl failed with output: %s', e.output)
       if parsed_options.local_run:
         logging.error(

docs/gpu/pixel_wrangling.md

@@ -202,12 +202,18 @@ shift, and a calendar appointment.
     rebaselined.
     1. For a given build failing the pixel tests, look for either:
         1. One or more links named `gold_triage_link for <test name>`. This will
-           be the case if there are fewer than 10 links.
+           be the case if there are fewer than 10 links. If the test was run on
+           a trybot, the link will instead be named
+           `triage_link_for_entire_cl for <test name>` (the weird naming comes
+           with how the recipe processes and displays links).
         1. A single link named
            `Too many artifacts produced to link individually, click for links`.
            This will be the case if there are 10 or more links.
     1. In either case, follow the link(s) to the triage page for the image the
        failing test produced.
+        1. If the test was run on a trybot, all the links will point to the same
+           page, which will be the triage page for every untriaged image
+           produced by the CL being tested.
     1. Ensure you are signed in to the Gold server the links take you to (both
        @google.com and @chromium.org accounts work).
     1. Triage images on those pages (typically by approving them, but you can